This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Add tests to make sure that stable algorithms work without memory available
ClosedPublic

Authored by philnik on Jun 14 2023, 11:04 AM.

Diff Detail

Event Timeline

philnik created this revision.Jun 14 2023, 11:04 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 14 2023, 11:04 AM
philnik requested review of this revision.Jun 14 2023, 11:04 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 14 2023, 11:04 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne added inline comments.
libcxx/test/std/algorithms/alg.modifying.operations/alg.partitions/stable_partition.pass.cpp
298

I think you want ->reset() here instead.

300

Same problem below as well.

libcxx/test/std/algorithms/alg.sorting/alg.merge/inplace_merge.pass.cpp
113–116

Indentation is wrong. Please also enclose this in braces to clearly delimit that it's a test of its own.

libcxx/test/support/count_new.h
423–429

Just to clarify, this is temporary to figure out whether that is what's causing the AIX issues right?

philnik updated this revision to Diff 531478.Jun 14 2023, 1:17 PM
philnik marked 4 inline comments as done.

Address comments

philnik added inline comments.Jun 14 2023, 1:19 PM
libcxx/test/support/count_new.h
423–429

Yes, this was a test - and that test failed.

ldionne accepted this revision.Jun 15 2023, 9:46 AM
ldionne added a subscriber: power-llvm-team.

LGTM but please don't forget to undo the temporary changes.

@power-llvm-team Could someone please have a look at the failures on AIX? We suspect those are related to how the linker handles weak defs being overridden in a user program. I ran into similar issues here: https://github.com/llvm/llvm-project/blob/main/libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.single/new.size_align_nothrow.replace.indirect.pass.cpp#L16

libcxx/utils/ci/buildkite-pipeline.yml
34

You need to get rid of this diff before shipping!

This revision is now accepted and ready to land.Jun 15 2023, 9:46 AM
This revision was automatically updated to reflect the committed changes.
philnik marked an inline comment as done.