Details
- Reviewers
ldionne - Group Reviewers
Restricted Project - Commits
- rGb935ab8e747c: [libc++] Add tests to make sure that stable algorithms work without memory…
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Event Timeline
libcxx/test/std/algorithms/alg.modifying.operations/alg.partitions/stable_partition.pass.cpp | ||
---|---|---|
298 | I think you want ->reset() here instead. | |
300 | Same problem below as well. | |
libcxx/test/std/algorithms/alg.sorting/alg.merge/inplace_merge.pass.cpp | ||
113–116 | Indentation is wrong. Please also enclose this in braces to clearly delimit that it's a test of its own. | |
libcxx/test/support/count_new.h | ||
423–429 | Just to clarify, this is temporary to figure out whether that is what's causing the AIX issues right? |
libcxx/test/support/count_new.h | ||
---|---|---|
423–429 | Yes, this was a test - and that test failed. |
LGTM but please don't forget to undo the temporary changes.
@power-llvm-team Could someone please have a look at the failures on AIX? We suspect those are related to how the linker handles weak defs being overridden in a user program. I ran into similar issues here: https://github.com/llvm/llvm-project/blob/main/libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.single/new.size_align_nothrow.replace.indirect.pass.cpp#L16
libcxx/utils/ci/buildkite-pipeline.yml | ||
---|---|---|
34 | You need to get rid of this diff before shipping! |
I think you want ->reset() here instead.