precommit tests for D147678 as we need tests cover BE too.
Details
Diff Detail
Unit Tests
Time | Test | |
---|---|---|
170 ms | x64 debian > LLVM.CodeGen/AArch64::neon-bitcast.ll |
Event Timeline
LGTM. I'm not sure these tests are checking anything very useful with how multiple bitcasts get combined away, but it sounds good in the context of D147678.
llvm/test/CodeGen/AArch64/neon-bitcast.ll | ||
---|---|---|
2–3 | Maybe use --check-prefixes=CHECK,CHECK-LE and --check-prefixes=CHECK,CHECK-BE, So the common code still reuse the same check lines. |
llvm/test/CodeGen/AArch64/neon-bitcast.ll | ||
---|---|---|
2–3 | Thanks for your idea. |
llvm/test/CodeGen/AArch64/neon-bitcast.ll | ||
---|---|---|
2–3 | No - in that case the test is OK as-is. Thanks. |
llvm/test/CodeGen/AArch64/neon-bitcast.ll | ||
---|---|---|
2–3 | Oh, it does work,thanks. Since the original cases happened to generate only CHECK, I thought it was invalid. |
use --check-prefixes=CHECK,CHECK-LE and --check-prefixes=CHECK,CHECK-BE, So the common code still reuse the same check lines
Maybe use --check-prefixes=CHECK,CHECK-LE and --check-prefixes=CHECK,CHECK-BE, So the common code still reuse the same check lines.