This is an archive of the discontinued LLVM Phabricator instance.

[test] Update the checking base for LE and BE
ClosedPublic

Authored by Allen on Jun 13 2023, 7:03 AM.

Details

Summary

precommit tests for D147678 as we need tests cover BE too.

Diff Detail

Event Timeline

Allen created this revision.Jun 13 2023, 7:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2023, 7:03 AM
Allen requested review of this revision.Jun 13 2023, 7:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2023, 7:03 AM
dmgreen accepted this revision.Jun 13 2023, 8:44 AM

LGTM. I'm not sure these tests are checking anything very useful with how multiple bitcasts get combined away, but it sounds good in the context of D147678.

llvm/test/CodeGen/AArch64/neon-bitcast.ll
2–3

Maybe use --check-prefixes=CHECK,CHECK-LE and --check-prefixes=CHECK,CHECK-BE, So the common code still reuse the same check lines.

This revision is now accepted and ready to land.Jun 13 2023, 8:44 AM
Allen added inline comments.Jun 13 2023, 9:54 PM
llvm/test/CodeGen/AArch64/neon-bitcast.ll
2–3

Thanks for your idea.
I find the update_llc_test_checks.py can't generate the checking result with common code automatically,
so we should manual maintenance the checking results if we use --check-prefixes=CHECK,CHECK-LE and --check-prefixes=CHECK,CHECK-BE ?

dmgreen added inline comments.Jun 14 2023, 1:27 AM
llvm/test/CodeGen/AArch64/neon-bitcast.ll
2–3

No - in that case the test is OK as-is. Thanks.

Allen marked 2 inline comments as done.Jun 14 2023, 6:37 AM
Allen added inline comments.
llvm/test/CodeGen/AArch64/neon-bitcast.ll
2–3

Oh, it does work,thanks.

Since the original cases happened to generate only CHECK, I thought it was invalid.

Allen updated this revision to Diff 531305.Jun 14 2023, 6:40 AM
Allen marked an inline comment as done.

use --check-prefixes=CHECK,CHECK-LE and --check-prefixes=CHECK,CHECK-BE, So the common code still reuse the same check lines

This revision was landed with ongoing or failed builds.Jun 14 2023, 8:34 AM
This revision was automatically updated to reflect the committed changes.