This is an archive of the discontinued LLVM Phabricator instance.

Differential D152742

[libc] Fix floating point test failing to build on the GPU
ClosedPublic

Authored by jhuber6 on Jun 12 2023, 12:19 PM.

Details

Reviewers
lntue
sivachandra
michaelrj
tra
Commits
rG746e72910fce: [libc] Fix floating point test failing to build on the GPU
Summary

A patch enabled this test which uses that add_fp_unittest.
Unfortunately we do not support these on the GPU because it attempts to
link in the floating point utils which are not built supporting
hermetic tests. This was attempted to be fixed in D151123 but that had
to be reverted. For now disable these so the tests pass.

Diff Detail

Event Timeline

jhuber6 created this revision.Jun 12 2023, 12:19 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 12 2023, 12:19 PM
Herald added a subscriber: libc-commits. · View Herald Transcript
jhuber6 requested review of this revision.Jun 12 2023, 12:19 PM
Harbormaster completed remote builds in B238279: Diff 530632.Jun 12 2023, 12:34 PM
tra accepted this revision.Jun 12 2023, 1:06 PM
This revision is now accepted and ready to land.Jun 12 2023, 1:06 PM
Closed by commit rG746e72910fce: [libc] Fix floating point test failing to build on the GPU (authored by jhuber6). · Explain WhyJun 12 2023, 1:06 PM
This revision was automatically updated to reflect the committed changes.
jhuber6 added a commit: rG746e72910fce: [libc] Fix floating point test failing to build on the GPU.
lntue mentioned this in D152873: [libc] Enable hermetic floating point tests again..Jun 13 2023, 5:45 PM
lntue mentioned this in rG055be3c30c78: [libc] Enable hermetic floating point tests again..Jun 14 2023, 7:54 AM

Revision Contents

PathSize
libc/
test/
src/
__support/
FPUtil/
42 lines

Diff 530648

libc/test/src/__support/FPUtil/CMakeLists.txt

add_custom_target(libc-fputil-tests) add_custom_target(libc-fputil-tests)
if(NOT LIBC_TARGET_ARCHITECTURE_IS_GPU)
add_fp_unittest( add_fp_unittest(
dyadic_float_test dyadic_float_test
NEED_MPFR NEED_MPFR
SUITE SUITE
libc-fputil-tests libc-fputil-tests
SRCS SRCS
dyadic_float_test.cpp dyadic_float_test.cpp
DEPENDS DEPENDS
libc.src.__support.FPUtil.dyadic_float libc.src.__support.FPUtil.dyadic_float
) )
endif()
add_libc_test( add_libc_test(
fpbits_test fpbits_test
SUITE SUITE
libc-fputil-tests libc-fputil-tests
SRCS SRCS
fpbits_test.cpp fpbits_test.cpp
DEPENDS DEPENDS
libc.src.__support.FPUtil.fp_bits libc.src.__support.FPUtil.fp_bits
libc.src.__support.FPUtil.fpbits_str libc.src.__support.FPUtil.fpbits_str
) )
if(NOT LIBC_TARGET_ARCHITECTURE_IS_GPU)
add_fp_unittest( add_fp_unittest(
rounding_mode_test rounding_mode_test
SUITE SUITE
libc-fputil-tests libc-fputil-tests
SRCS SRCS
rounding_mode_test.cpp rounding_mode_test.cpp
DEPENDS DEPENDS
libc.src.__support.FPUtil.rounding_mode libc.src.__support.FPUtil.rounding_mode
) )
endif()