This is an archive of the discontinued LLVM Phabricator instance.

[HIP] Fix HIP path detection
ClosedPublic

Authored by yaxunl on Jun 12 2023, 10:51 AM.

Details

Summary

Fix two issues:

  1. --hip-path should not do rigorous checking, i.e. if .hipVersion exists it will use it, otherwise it will not error out but assumes the default HIP version. This is to be consistent with --rocm-path behavior.
  1. when HIP_PATH is empty, it should be ignored. This is to be consistent with ROCM_PATH behavior.

Diff Detail

Event Timeline

yaxunl created this revision.Jun 12 2023, 10:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2023, 10:51 AM
yaxunl requested review of this revision.Jun 12 2023, 10:51 AM
tra accepted this revision.Jun 12 2023, 10:58 AM
This revision is now accepted and ready to land.Jun 12 2023, 10:58 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2023, 8:12 AM