This is an archive of the discontinued LLVM Phabricator instance.

[libc] Fix argument types for {f,}truncate specs
ClosedPublic

Authored by alfredfo on Jun 11 2023, 7:03 PM.

Details

Summary

The current argument types are currently switched around for ftruncate
and truncate. Currently passes tests because the internal definitions
inside the __llvm_libc namespace are fine.

Diff Detail

Event Timeline

alfredfo created this revision.Jun 11 2023, 7:03 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 11 2023, 7:03 PM
alfredfo requested review of this revision.Jun 11 2023, 7:03 PM
alfredfo updated this revision to Diff 530359.Jun 11 2023, 7:30 PM

[libc] Fix argument types for {f,}truncate specs

s/ConstCharType/ConstCharPtr

thesamesam accepted this revision.Jun 11 2023, 8:28 PM

lgtm, but not a member of llvm-libc

This revision is now accepted and ready to land.Jun 11 2023, 8:28 PM
sivachandra accepted this revision.Jun 11 2023, 9:41 PM
sivachandra added a subscriber: sivachandra.

Thanks for catching this.

This revision was automatically updated to reflect the committed changes.