This is an archive of the discontinued LLVM Phabricator instance.

Differential D152656

[libc++][spaceship][NFC] P1612R2: Mark some items "remove `operator!=` from `*_iterator`" as "Complete"
ClosedPublic

Authored by H-G-Hristov on Jun 11 2023, 12:46 PM.

Details

Reviewers
Mordante
Group Reviewers
Restricted Project
Commits
rG5a53323d2c14: [libc++][spaceship][NFC] P1612R2: Mark some items "remove `operator!=` from…
Summary

Several parts of P1612R2 are already implemented:

Diff Detail

Event Timeline

H-G-Hristov created this revision.Jun 11 2023, 12:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 11 2023, 12:46 PM
Herald added a subscriber: yaxunl. · View Herald Transcript
Harbormaster completed remote builds in B238048: Diff 530325.Jun 11 2023, 8:11 PM
H-G-Hristov published this revision for review.Jun 12 2023, 12:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2023, 12:16 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
H-G-Hristov retitled this revision from [libc++][spaceship][NFC] P1612R2: Mark remove `operator!=` from `istream_iterator`, `istreambuf_iterator` as "Complete" to [libc++][spaceship][NFC] P1612R2: Mark some items "remove `operator!=` from `*_iterator`" as "Complete".Jun 12 2023, 12:32 AM
H-G-Hristov edited the summary of this revision. (Show Details)
H-G-Hristov edited the summary of this revision. (Show Details)
H-G-Hristov updated this revision to Diff 530412.Jun 12 2023, 12:38 AM

Mark more items as complete

Harbormaster completed remote builds in B238118: Diff 530412.Jun 12 2023, 4:12 AM
H-G-Hristov added a reviewer: Mordante.Jun 12 2023, 4:49 AM
Mordante accepted this revision.Jun 12 2023, 9:21 AM

LGTM modulo one nit.

libcxx/docs/Status/SpaceshipProjects.csv
118
This revision is now accepted and ready to land.Jun 12 2023, 9:21 AM
H-G-Hristov updated this revision to Diff 530574.Jun 12 2023, 10:15 AM

Addressed review comment

H-G-Hristov marked an inline comment as done.Jun 12 2023, 10:16 AM
Harbormaster completed remote builds in B238238: Diff 530574.Jun 12 2023, 4:14 PM
Closed by commit rG5a53323d2c14: [libc++][spaceship][NFC] P1612R2: Mark some items "remove `operator!=` from… (authored by Zingam). · Explain WhyJun 12 2023, 9:44 PM
This revision was automatically updated to reflect the committed changes.
Zingam added a commit: rG5a53323d2c14: [libc++][spaceship][NFC] P1612R2: Mark some items "remove `operator!=` from….

Revision Contents

PathSize
libcxx/
docs/
Status/
8 lines

Diff 530412

libcxx/docs/Status/SpaceshipProjects.csv

Show First 20 Lines • Show All 105 Lines • ▼ Show 20 Lines
| `[queue.ops] <https://wg21.link/queue.ops>`_,| `queue <https://reviews.llvm.org/D146066>`_,None,Hristo Hristov,|Complete| | `[queue.ops] <https://wg21.link/queue.ops>`_,| `queue <https://reviews.llvm.org/D146066>`_,None,Hristo Hristov,|Complete|
| `[stack.ops] <https://wg21.link/stack.ops>`_,| `stack <https://reviews.llvm.org/D146094>`_,None,Hristo Hristov,|Complete| | `[stack.ops] <https://wg21.link/stack.ops>`_,| `stack <https://reviews.llvm.org/D146094>`_,None,Hristo Hristov,|Complete|
- `5.8 Clause 23: Iterators library <https://wg21.link/p1614r2#clause-23-iterators-library>`_,,,, - `5.8 Clause 23: Iterators library <https://wg21.link/p1614r2#clause-23-iterators-library>`_,,,,
| `[iterator.synopsis] <https://wg21.link/iterator.synopsis>`_,|,None,Unassigned,|Not Started| | `[iterator.synopsis] <https://wg21.link/iterator.synopsis>`_,|,None,Unassigned,|Not Started|
| `[reverse.iter.cmp] <https://wg21.link/reverse.iter.cmp>`_,| `reverse_iterator <https://reviews.llvm.org/D113695>`_,None,Mikhail Maltsev,|Complete| | `[reverse.iter.cmp] <https://wg21.link/reverse.iter.cmp>`_,| `reverse_iterator <https://reviews.llvm.org/D113695>`_,None,Mikhail Maltsev,|Complete|
"| `[move.iterator] <https://wg21.link/move.iterator>`_ "| `[move.iterator] <https://wg21.link/move.iterator>`_
| `[move.iter.op.comp] <https://wg21.link/move.iter.op.comp>`_",| `move_iterator <https://reviews.llvm.org/D117656>`_,None,Arthur O'Dwyer,|Complete| | `[move.iter.op.comp] <https://wg21.link/move.iter.op.comp>`_",| `move_iterator <https://reviews.llvm.org/D117656>`_,None,Arthur O'Dwyer,|Complete|
"| `[common.iterator] <https://wg21.link/common.iterator>`_ "| `[common.iterator] <https://wg21.link/common.iterator>`_
| `[common.iter.cmp] <https://wg21.link/common.iter.cmp>`_",| remove ops `common_iterator`,None,Unassigned,|Not Started| | `[common.iter.cmp] <https://wg21.link/common.iter.cmp>`_",| `common_iterator <https://reviews.llvm.org/D103335>`_,None,Zoe Carver,|Complete|
"| `[counted.iterator] <https://wg21.link/counted.iterator>`_ "| `[counted.iterator] <https://wg21.link/counted.iterator>`_
| `[counted.iter.cmp] <https://wg21.link/counted.iter.cmp>`_",| `counted_iterator <https://reviews.llvm.org/D106205>`_,None,Zoe Carver,|Complete| | `[counted.iter.cmp] <https://wg21.link/counted.iter.cmp>`_",| `counted_iterator <https://reviews.llvm.org/D106205>`_,None,Zoe Carver,|Complete|
"| `[unreachable.sentinel] <https://wg21.link/unreachable.sentinel>`_ "| `[unreachable.sentinel] <https://wg21.link/unreachable.sentinel>`_
| `[unreachable.sentinel.cmp] <https://wg21.link/common.iter.cmp>`_",| `unreachable_sentinel_t`,None,Unassigned,|Not Started| | `[unreachable.sentinel.cmp] <https://wg21.link/common.iter.cmp>`_",| `unreachable_sentinel_t <https://reviews.llvm.org/D107920>`_,None,Zoe Carver,|Complete|
MordanteUnsubmitted
Done
ReplyInline Actions
"| `[unreachable.sentinel] <https://wg21.link/unreachable.sentinel>`_
- | `[unreachable.sentinel.cmp] <https://wg21.link/common.iter.cmp>`_",| `unreachable_sentinel_t <https://reviews.llvm.org/D107920>`_,None,Zoe Carver,|Complete|
+ | `[unreachable.sentinel] <https://eel.is/c++draft/unreachable.sentinel>`_",| `unreachable_sentinel_t <https://reviews.llvm.org/D107920>`_,None,Zoe Carver,|Complete|
"| `[istream.iterator] <https://wg21.link/istream.iterator>`_
Mordante:
"| `[istream.iterator] <https://wg21.link/istream.iterator>`_ "| `[istream.iterator] <https://wg21.link/istream.iterator>`_
| `[istream.iterator.ops] <https://wg21.link/istream.iterator.ops>`_",| remove ops `istream_iterator`,None,Unassigned,|Not Started| | `[istream.iterator.ops] <https://wg21.link/istream.iterator.ops>`_",| remove ops `istream_iterator <https://reviews.llvm.org/D119620>`_,None,Konstantin Varlamov,|Complete|
"| `[istreambuf.iterator] <https://wg21.link/istreambuf.iterator>`_ "| `[istreambuf.iterator] <https://wg21.link/istreambuf.iterator>`_
| `[istreambuf.iterator.ops] <https://wg21.link/istreambuf.iterator.ops>`_",| remove ops `istreambuf_iterator`,None,Unassigned,|Not Started| | `[istreambuf.iterator.ops] <https://wg21.link/istreambuf.iterator.ops>`_",| remove ops `istreambuf_iterator <https://reviews.llvm.org/D119620>`_,None,Konstantin Varlamov,|Complete|
- `5.9 Clause 24: Ranges library <https://wg21.link/p1614r2#clause-24-ranges-library>`_,,,, - `5.9 Clause 24: Ranges library <https://wg21.link/p1614r2#clause-24-ranges-library>`_,,,,
| `[range.iota.iterator] <https://wg21.link/range.iota.iterator>`_,| `ranges::iota_view::iterator <https://reviews.llvm.org/D110774>`_,[concepts.cmp],Arthur O'Dwyer,|Complete| | `[range.iota.iterator] <https://wg21.link/range.iota.iterator>`_,| `ranges::iota_view::iterator <https://reviews.llvm.org/D110774>`_,[concepts.cmp],Arthur O'Dwyer,|Complete|
| `[range.iota.sentinel] <https://wg21.link/range.iota.sentinel>`_,| remove ops `iota_view::sentinel`,None,Unassigned,|Not Started| | `[range.iota.sentinel] <https://wg21.link/range.iota.sentinel>`_,| remove ops `iota_view::sentinel`,None,Unassigned,|Not Started|
| `[range.filter.iterator] <https://wg21.link/range.filter.iterator>`_,| remove ops `filter_view::iterator`,None,Unassigned,|Not Started| | `[range.filter.iterator] <https://wg21.link/range.filter.iterator>`_,| remove ops `filter_view::iterator`,None,Unassigned,|Not Started|
| `[range.filter.sentinel] <https://wg21.link/range.filter.sentinel>`_,| remove ops `filter_view::sentinel`,None,Unassigned,|Not Started| | `[range.filter.sentinel] <https://wg21.link/range.filter.sentinel>`_,| remove ops `filter_view::sentinel`,None,Unassigned,|Not Started|
| `[range.transform.iterator] <https://wg21.link/range.transform.iterator>`_,| `ranges::transform_view::iterator <https://reviews.llvm.org/D110774>`_,[concepts.cmp],Arthur O'Dwyer,|Complete| | `[range.transform.iterator] <https://wg21.link/range.transform.iterator>`_,| `ranges::transform_view::iterator <https://reviews.llvm.org/D110774>`_,[concepts.cmp],Arthur O'Dwyer,|Complete|
| `[range.transform.sentinel] <https://wg21.link/range.transform.sentinel>`_,| remove ops `transform_view::sentinel`,None,Unassigned,|Not Started| | `[range.transform.sentinel] <https://wg21.link/range.transform.sentinel>`_,| remove ops `transform_view::sentinel`,None,Unassigned,|Not Started|
| `[range.take.sentinel] <https://wg21.link/range.take.sentinel>`_,| remove ops `take_view::sentinel`,None,Unassigned,|Not Started| | `[range.take.sentinel] <https://wg21.link/range.take.sentinel>`_,| remove ops `take_view::sentinel`,None,Unassigned,|Not Started|
▲ Show 20 Lines • Show All 75 Lines • Show Last 20 Lines