This is an archive of the discontinued LLVM Phabricator instance.

[libc++][spaceship][NFC] P1612R2: Mark some items "remove `operator!=` from `*_iterator`" as "Complete"
ClosedPublic

Authored by H-G-Hristov on Jun 11 2023, 12:46 PM.

Details

Summary

Several parts of P1612R2 are already implemented:

Diff Detail

Event Timeline

H-G-Hristov created this revision.Jun 11 2023, 12:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 11 2023, 12:46 PM
Herald added a subscriber: yaxunl. · View Herald Transcript
H-G-Hristov published this revision for review.Jun 12 2023, 12:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2023, 12:16 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
H-G-Hristov retitled this revision from [libc++][spaceship][NFC] P1612R2: Mark remove `operator!=` from `istream_iterator`, `istreambuf_iterator` as "Complete" to [libc++][spaceship][NFC] P1612R2: Mark some items "remove `operator!=` from `*_iterator`" as "Complete".Jun 12 2023, 12:32 AM
H-G-Hristov edited the summary of this revision. (Show Details)
H-G-Hristov edited the summary of this revision. (Show Details)

Mark more items as complete

Mordante accepted this revision.Jun 12 2023, 9:21 AM

LGTM modulo one nit.

libcxx/docs/Status/SpaceshipProjects.csv
118
This revision is now accepted and ready to land.Jun 12 2023, 9:21 AM

Addressed review comment

H-G-Hristov marked an inline comment as done.Jun 12 2023, 10:16 AM