str method of FPBits class is only used for pretty printing its objects
in tests. It brings cpp::string dependency to FPBits class, which is not ideal
for embedded use case. We move str method to a free function in test utils and
remove this dependency of FPBits class.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
LGTM but a comment about putting the new function in a different place.
libc/test/UnitTest/StringUtils.h | ||
---|---|---|
22 ↗ | (On Diff #530143) | I am planning to get rid of this also as it is duplicated functionality without tests. Also, adding code here but test in test/src/__support breaks our structuring. Can you move the new str function to say src/__support/FPUtil/fpbits_str.h ? |