This is an archive of the discontinued LLVM Phabricator instance.

[clang-format] Remove redundant test case
ClosedPublic

Authored by paulkirth on Jun 9 2023, 2:18 PM.

Details

Summary

The test is now properly covered in unit tests, and shouldn't have been
added in the initial commit of D152473.

Diff Detail

Event Timeline

paulkirth created this revision.Jun 9 2023, 2:18 PM
Herald added projects: Restricted Project, Restricted Project, Restricted Project. · View Herald TranscriptJun 9 2023, 2:18 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
paulkirth requested review of this revision.Jun 9 2023, 2:18 PM
NOTE: Clang-Format Team Automated Review Comment

It looks like your clang-format review does not contain any unit tests, please try to ensure all code changes have a unit test (unless this is an NFC or refactoring, adding documentation etc..)

Add your unit tests in clang/unittests/Format and you can build with ninja FormatTests. We recommend using the verifyFormat(xxx) format of unit tests rather than EXPECT_EQ as this will ensure you change is tolerant to random whitespace changes (see FormatTest.cpp as an example)

For situations where your change is altering the TokenAnnotator.cpp which can happen if you are trying to improve the annotation phase to ensure we are correctly identifying the type of a token, please add a token annotator test in TokenAnnotatorTest.cpp

owenpan accepted this revision.Jun 9 2023, 4:29 PM
This revision is now accepted and ready to land.Jun 9 2023, 4:29 PM
This revision was landed with ongoing or failed builds.Jun 9 2023, 4:41 PM
This revision was automatically updated to reflect the committed changes.