This is an archive of the discontinued LLVM Phabricator instance.

Differential D152528

[NewGVN] Precommit test for folding freeze
ClosedPublic

Authored by foad on Jun 9 2023, 5:47 AM.

Details

Reviewers
foad
fhahn
Commits
rGb27b5dcc00db: [NewGVN] Precommit test for folding freeze

Diff Detail

Event Timeline

foad created this revision.Jun 9 2023, 5:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 9 2023, 5:47 AM
Herald added subscribers: kmitropoulou, StephenFan. · View Herald Transcript
foad requested review of this revision.Jun 9 2023, 5:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 9 2023, 5:47 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
foad accepted this revision.Jun 9 2023, 5:48 AM
foad added a child revision: D152529: [NewGVN] Fold equivalent freeze instructions.

Self-approving.

This revision is now accepted and ready to land.Jun 9 2023, 5:50 AM
nikic added a subscriber: nikic.Jun 9 2023, 5:51 AM
nikic added inline comments.
llvm/test/Transforms/NewGVN/freeze.ll
12

Was this supposed to use %b, %c?

foad added a subscriber: aqjune.Jun 9 2023, 5:53 AM
foad added inline comments.
llvm/test/Transforms/NewGVN/freeze.ll
12

Probably! I copied it verbatim from the GVN test, added in D75398. @aqjune?

foad planned changes to this revision.Jun 9 2023, 5:53 AM
Harbormaster completed remote builds in B237743: Diff 529930.Jun 9 2023, 6:52 AM
foad updated this revision to Diff 529966.Jun 9 2023, 7:41 AM

Fix typo.

This revision is now accepted and ready to land.Jun 9 2023, 7:41 AM
Harbormaster completed remote builds in B237766: Diff 529966.Jun 9 2023, 9:30 AM
fhahn accepted this revision.Jun 9 2023, 12:08 PM
fhahn added a subscriber: fhahn.

LGTM, thanks!

Closed by commit rGb27b5dcc00db: [NewGVN] Precommit test for folding freeze (authored by foad). · Explain WhyJun 9 2023, 1:03 PM
This revision was automatically updated to reflect the committed changes.
foad added a commit: rGb27b5dcc00db: [NewGVN] Precommit test for folding freeze.

Revision Contents

PathSize
llvm/
test/
Transforms/
NewGVN/
58 lines

Diff 530063

llvm/test/Transforms/NewGVN/freeze.ll

  • This file was added.
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt < %s -passes=newgvn -S | FileCheck %s
define i1 @f(i1 %a) {
; CHECK-LABEL: @f(
; CHECK-NEXT: [[B:%.*]] = freeze i1 [[A:%.*]]
; CHECK-NEXT: [[C:%.*]] = freeze i1 [[A]]
; CHECK-NEXT: [[D:%.*]] = and i1 [[B]], [[C]]
; CHECK-NEXT: ret i1 [[D]]
;
%b = freeze i1 %a
%c = freeze i1 %a
nikicUnsubmitted
Not Done
ReplyInline Actions

Was this supposed to use %b, %c?

nikic: Was this supposed to use `%b, %c`?
foadAuthorUnsubmitted
Done
ReplyInline Actions

Probably! I copied it verbatim from the GVN test, added in D75398. @aqjune?

foad: Probably! I copied it verbatim from the GVN test, added in D75398. @aqjune?
%d = and i1 %b, %c
ret i1 %d
}
define void @f_multipleuses(i1 %a) {
; CHECK-LABEL: @f_multipleuses(
; CHECK-NEXT: [[B:%.*]] = freeze i1 [[A:%.*]]
; CHECK-NEXT: [[C:%.*]] = freeze i1 [[A]]
; CHECK-NEXT: call void @use1(i1 [[B]])
; CHECK-NEXT: call void @use1(i1 [[C]])
; CHECK-NEXT: call void @use1(i1 [[C]])
; CHECK-NEXT: ret void
;
%b = freeze i1 %a
%c = freeze i1 %a
call void @use1(i1 %b)
call void @use1(i1 %c)
call void @use1(i1 %c)
ret void
}
define void @f_dom(i1 %cond, i1 %a) {
; CHECK-LABEL: @f_dom(
; CHECK-NEXT: br i1 [[COND:%.*]], label [[BB1:%.*]], label [[BB2:%.*]]
; CHECK: BB1:
; CHECK-NEXT: [[X:%.*]] = freeze i1 [[A:%.*]]
; CHECK-NEXT: call void @use1(i1 [[X]])
; CHECK-NEXT: ret void
; CHECK: BB2:
; CHECK-NEXT: [[Y:%.*]] = freeze i1 [[A]]
; CHECK-NEXT: call void @use2(i1 [[Y]])
; CHECK-NEXT: ret void
;
br i1 %cond, label %BB1, label %BB2
BB1:
%x = freeze i1 %a
call void @use1(i1 %x)
ret void
BB2:
%y = freeze i1 %a
call void @use2(i1 %y) ; cannot use %x
ret void
}
declare void @use1(i1)
declare void @use2(i1)