This is an archive of the discontinued LLVM Phabricator instance.

Differential D152485

Fix regex in test case so that it doesn't match "coverage" in directory names
ClosedPublic

Authored by ahatanak on Jun 8 2023, 4:28 PM.

Details

Reviewers
tra
MaskRay
azharudd
Commits
rGde3c01b06fe5: Fix regex in test case so that it doesn't match "coverage" in directory
Summary

The test case was failing because "-f{{[^"]*coverage.*}}" was matching the following string:

"-fdebug-compilation-dir=/Users/buildslave/jenkins/workspace/coverage/"

Diff Detail

Event Timeline

ahatanak created this revision.Jun 8 2023, 4:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 8 2023, 4:28 PM
Herald added a subscriber: wenlei. · View Herald Transcript
ahatanak requested review of this revision.Jun 8 2023, 4:28 PM

Example of the test failing: https://green.lab.llvm.org/green/job/coverage/467/consoleText

Harbormaster completed remote builds in B237622: Diff 529773.Jun 8 2023, 4:58 PM
azharudd accepted this revision.Jun 9 2023, 11:58 AM
This revision is now accepted and ready to land.Jun 9 2023, 11:58 AM
Closed by commit rGde3c01b06fe5: Fix regex in test case so that it doesn't match "coverage" in directory (authored by ahatanak). · Explain WhyJun 9 2023, 2:21 PM
This revision was automatically updated to reflect the committed changes.
ahatanak added a commit: rGde3c01b06fe5: Fix regex in test case so that it doesn't match "coverage" in directory.

Revision Contents

PathSize
clang/
test/
Driver/
2 lines

Diff 530081

clang/test/Driver/cuda-no-pgo-or-coverage.cu

Show All 20 Lines
// RUN: %clang -### --target=x86_64-linux-gnu -c --cuda-gpu-arch=sm_20 \ // RUN: %clang -### --target=x86_64-linux-gnu -c --cuda-gpu-arch=sm_20 \
// RUN: -fprofile-instr-generate -fcoverage-mapping %s 2>&1 | \ // RUN: -fprofile-instr-generate -fcoverage-mapping %s 2>&1 | \
// RUN: FileCheck --check-prefixes=CHECK,PROF %s // RUN: FileCheck --check-prefixes=CHECK,PROF %s
// //
// //
// CHECK-NOT: error: unsupported option '-fprofile // CHECK-NOT: error: unsupported option '-fprofile
// CHECK-NOT: error: invalid argument // CHECK-NOT: error: invalid argument
// CHECK-DAG: "-fcuda-is-device" // CHECK-DAG: "-fcuda-is-device"
// CHECK-NOT: "-f{{[^"]*coverage.*}}" // CHECK-NOT: "-f{{[^"/]*coverage.*}}"
// CHECK-NOT: "-fprofile{{[^"]*}}" // CHECK-NOT: "-fprofile{{[^"]*}}"
// CHECK: "-triple" "x86_64-unknown-linux-gnu" // CHECK: "-triple" "x86_64-unknown-linux-gnu"
// PROF: "-fprofile{{.*}}" // PROF: "-fprofile{{.*}}"
// GCOV: "-coverage-notes-file" // GCOV: "-coverage-notes-file"