This is an archive of the discontinued LLVM Phabricator instance.

[clang] set python3 as required build dependency
ClosedPublic

Authored by Avimitin on Jun 7 2023, 9:19 PM.

Details

Summary

The required HTMLLogger include file needs python3 to run resource_bundle.py to bundle all the html/css/js resources. However, if user sets -DLLVM_INCLUDE_TESTS=OFF, CMake will not find python3 and the resource bundler will never be executed. This patch set the python3 as a required build dependency to fix this problem.

Diff Detail

Event Timeline

Avimitin created this revision.Jun 7 2023, 9:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 7 2023, 9:19 PM
Avimitin requested review of this revision.Jun 7 2023, 9:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 7 2023, 9:19 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Avimitin edited the summary of this revision. (Show Details)Jun 7 2023, 9:20 PM
phosek accepted this revision.Jun 7 2023, 10:51 PM

LGTM

This revision is now accepted and ready to land.Jun 7 2023, 10:51 PM

I can't commit this change myself, please help me commit this, thank you.

This revision was automatically updated to reflect the committed changes.