[lldb] Never print children if the max depth has been reached

[augusto2112]

Summary

When formatting a variable, the max depth would potentially be ignored
if the current value object failed to print itself. Change that to
always respect the max depth, even if failure occurs

rdar://109855463

[augusto2112]

Remove failure check

[aprantl]

Would that be testable by implementing a python data formatter for a C struct that unconditionally returns an error?

lldb/source/DataFormatters/ValueObjectPrinter.cpp

bool ValueObjectPrinter::ShouldPrintChildren(
     DumpValueObjectOptions::PointerDepth &curr_ptr_depth) {
   const bool is_ref = IsRef();
   const bool is_ptr = IsPtr();
   const bool is_uninit = IsUninitialized();
 
   if (is_uninit)
     return false;
 
+  // If we have reached the maximum depth we shouldn't print any more children.
+  if (HasReachedMaximumDepth())
+    return false;
+
   // if the user has specified an element count, always print children as it is
   // explicit user demand being honored
   if (m_options.m_pointer_as_array)
     return true;
 
   if (m_options.m_use_objc)
     return false;
 
   bool print_children = true;
   if (TypeSummaryImpl *type_summary = GetSummaryFormatter())
     print_children = type_summary->DoesPrintChildren(m_valobj);
 
-  if (is_failed_description || !HasReachedMaximumDepth()) {
+  if (is_failed_description) {
     // We will show children for all concrete types. We won't show pointer
     // contents unless a pointer depth has been specified. We won't reference
     // contents unless the reference is the root object (depth of zero).
 
     // Use a new temporary pointer depth in case we override the current
     // pointer depth below...
 
     if (is_ptr || is_ref) {