This is an archive of the discontinued LLVM Phabricator instance.

[InstCombine] Add tests for equality `icmp` with rotates; NFC
ClosedPublic

Authored by goldstein.w.n on Jun 7 2023, 1:15 AM.

Diff Detail

Event Timeline

goldstein.w.n created this revision.Jun 7 2023, 1:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 7 2023, 1:15 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
goldstein.w.n requested review of this revision.Jun 7 2023, 1:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 7 2023, 1:15 AM
nikic added a comment.Jun 7 2023, 2:00 AM

Missing negative test with non-equality comparison.

Missing negative test with non-equality comparison.

Done.

Add non-equality failure cases

Add tests for rotate(X) with rotate(Y)

nikic accepted this revision.Jun 7 2023, 12:56 PM

LGTM

llvm/test/Transforms/InstCombine/icmp-equality-rotate.ll
40

Can also add a test where the rotate and icmp operands are different.

This revision is now accepted and ready to land.Jun 7 2023, 12:56 PM

Add tests for comparing rorr to another var

goldstein.w.n marked an inline comment as done.Jun 7 2023, 1:16 PM