This is an archive of the discontinued LLVM Phabricator instance.

[libc] Silence warning about returning from noreturn function
ClosedPublic

Authored by jhuber6 on Jun 6 2023, 5:29 PM.

Details

Summary

The exit entrypoint calls into quick_exit which is marked noreturn
in some cases. This will cause errors because we then have control flow
externally. This warning can be silenced by using a
__builtin_unreachable instruction accordingly.

Diff Detail

Event Timeline

jhuber6 created this revision.Jun 6 2023, 5:29 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 6 2023, 5:29 PM
jhuber6 requested review of this revision.Jun 6 2023, 5:29 PM
lntue accepted this revision.Jun 6 2023, 5:42 PM
This revision is now accepted and ready to land.Jun 6 2023, 5:42 PM
sivachandra accepted this revision.Jun 6 2023, 10:10 PM