This is an archive of the discontinued LLVM Phabricator instance.

[clang][test] Use a physical copy of FS
ClosedPublic

Authored by kadircet on Jun 6 2023, 6:41 AM.
Tokens
"Love" token, awarded by goncharov.

Details

Summary

Make use of a physical copy, rather than real FS in unittests that
change working-directory to get rid of the side effect of changing cwd for the
whole process. It's triggering crashes depending on the test order.

Diff Detail

Event Timeline

kadircet created this revision.Jun 6 2023, 6:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 6 2023, 6:41 AM
kadircet requested review of this revision.Jun 6 2023, 6:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 6 2023, 6:41 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
kadircet updated this revision to Diff 528834.Jun 6 2023, 6:42 AM
  • Fix test
goncharov accepted this revision.Jun 6 2023, 6:43 AM
goncharov added a subscriber: goncharov.

nice

This revision is now accepted and ready to land.Jun 6 2023, 6:44 AM
This revision was landed with ongoing or failed builds.Jun 6 2023, 6:48 AM
This revision was automatically updated to reflect the committed changes.