This is an archive of the discontinued LLVM Phabricator instance.

Differential D152155

[AppleAccelTable][NFC] Remove `struct` keyword from member decl
ClosedPublic

Authored by fdeazeve on Jun 5 2023, 6:44 AM.

Details

Reviewers
None
Commits
rG8b7f379dc832: [AppleAccelTable][NFC] Remove `struct` keyword from member decl
Summary

This is only needed in C.

Diff Detail

Event Timeline

fdeazeve created this revision.Jun 5 2023, 6:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 5 2023, 6:44 AM
fdeazeve requested review of this revision.Jun 5 2023, 6:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 5 2023, 6:44 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
fdeazeve added a child revision: D152156: [AppleAccelTable][NFC] Make FormParams member of AppleAccelTable.Jun 5 2023, 6:44 AM
fdeazeve added reviewers: aprantl, JDevlieghere, debug-info.Jun 5 2023, 6:51 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 5 2023, 6:55 AM
This revision was landed with ongoing or failed builds.
Closed by commit rG8b7f379dc832: [AppleAccelTable][NFC] Remove `struct` keyword from member decl (authored by fdeazeve). · Explain Why
This revision was automatically updated to reflect the committed changes.
fdeazeve added a commit: rG8b7f379dc832: [AppleAccelTable][NFC] Remove `struct` keyword from member decl.
fdeazeve added a comment.Jun 5 2023, 6:55 AM

Honestly this probably doesn't need review, I've committed it.

fdeazeve edited the summary of this revision. (Show Details)Jun 5 2023, 6:59 AM
fdeazeve removed reviewers: aprantl, JDevlieghere, debug-info.
Harbormaster completed remote builds in B236609: Diff 528411.Jun 5 2023, 7:34 AM

Revision Contents

PathSize
llvm/
include/
llvm/
DebugInfo/
DWARF/
4 lines

Diff 528411

llvm/include/llvm/DebugInfo/DWARF/DWARFAcceleratorTable.h

Show First 20 Lines • Show All 97 Lines • ▼ Show 20 Lines struct HeaderData {
uint64_t DIEOffsetBase; uint64_t DIEOffsetBase;
SmallVector<std::pair<AtomType, Form>, 3> Atoms; SmallVector<std::pair<AtomType, Form>, 3> Atoms;
std::optional<uint64_t> std::optional<uint64_t>
extractOffset(std::optional<DWARFFormValue> Value) const; extractOffset(std::optional<DWARFFormValue> Value) const;
}; };
struct Header Hdr; Header Hdr;
struct HeaderData HdrData; HeaderData HdrData;
bool IsValid = false; bool IsValid = false;
/// Returns true if we should continue scanning for entries or false if we've /// Returns true if we should continue scanning for entries or false if we've
/// reached the last (sentinel) entry of encountered a parsing error. /// reached the last (sentinel) entry of encountered a parsing error.
bool dumpName(ScopedPrinter &W, SmallVectorImpl<DWARFFormValue> &AtomForms, bool dumpName(ScopedPrinter &W, SmallVectorImpl<DWARFFormValue> &AtomForms,
uint64_t *DataOffset) const; uint64_t *DataOffset) const;
/// Reads an uint32_t from the accelerator table at Offset, which is /// Reads an uint32_t from the accelerator table at Offset, which is
▲ Show 20 Lines • Show All 568 Lines • Show Last 20 Lines