This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] Expand vector SDIVREM/UDIVREM
ClosedPublic

Authored by apazos on Dec 3 2015, 3:32 PM.

Details

Reviewers
t.p.northover
Summary

While experimenting with vectorization I came across a backend failure in lowering vector SDIVREM/UDIVREM. So expanding these vector operations as we already do for the scalar ones.

Diff Detail

Event Timeline

apazos updated this revision to Diff 41813.Dec 3 2015, 3:32 PM
apazos retitled this revision from to [AArch64] Expand vector SDIVREM/UDIVREM.
apazos updated this object.

The change looks fine, but we should add a test too.

apazos updated this revision to Diff 41903.Dec 4 2015, 11:41 AM

Hi Tim, I added a test case, let me know if you want any other change.

t.p.northover accepted this revision.Dec 4 2015, 12:01 PM
t.p.northover added a reviewer: t.p.northover.

Thanks for adding the tests. You can probably drop the CHECK-NOT lines (the test would fail via its exit code and they'd go to stderr anyway). Other than that this looks fine.

Tim.

This revision is now accepted and ready to land.Dec 4 2015, 12:01 PM
mcrosier closed this revision.Dec 4 2015, 1:42 PM
mcrosier added a subscriber: mcrosier.

Committed in r254773.