This is an archive of the discontinued LLVM Phabricator instance.

Differential D152089

[InstCombine] precommit test for D152088(NFC)
ClosedPublic

Authored by khei4 on Jun 3 2023, 9:10 PM.

Details

Reviewers
nikic
goldstein.w.n
spatel
Commits
rG0505fcdccd5d: [InstCombine] precommit test for D152088(NFC)
Summary

pre-commit test for https://reviews.llvm.org/D152088

Diff Detail

Event Timeline

khei4 created this revision.Jun 3 2023, 9:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 3 2023, 9:10 PM
Herald added a subscriber: StephenFan. · View Herald Transcript
khei4 requested review of this revision.Jun 3 2023, 9:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 3 2023, 9:10 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
khei4 added a child revision: D152088: [InstCombine] add nsw on InstCombineAdd ~X + C --> (C-1) - X.Jun 3 2023, 9:11 PM
Harbormaster completed remote builds in B236432: Diff 528179.Jun 3 2023, 9:44 PM
khei4 updated this revision to Diff 528271.Jun 4 2023, 8:57 PM

Add nuw case and non-splat vector cases

khei4 mentioned this in D152088: [InstCombine] add nsw on InstCombineAdd ~X + C --> (C-1) - X.Jun 4 2023, 8:58 PM
Harbormaster completed remote builds in B236506: Diff 528271.Jun 4 2023, 9:56 PM
khei4 updated this revision to Diff 528369.Jun 5 2023, 4:04 AM

rebase

Harbormaster completed remote builds in B236582: Diff 528369.Jun 5 2023, 4:37 AM
nikic accepted this revision.Jun 5 2023, 5:44 AM
This revision is now accepted and ready to land.Jun 5 2023, 5:44 AM
Closed by commit rG0505fcdccd5d: [InstCombine] precommit test for D152088(NFC) (authored by khei4). · Explain WhyJun 5 2023, 8:43 PM
This revision was automatically updated to reflect the committed changes.
khei4 added a commit: rG0505fcdccd5d: [InstCombine] precommit test for D152088(NFC).

Revision Contents

PathSize
llvm/
test/
Transforms/
InstCombine/
76 lines

Diff 528672

llvm/test/Transforms/InstCombine/add.ll

Show First 20 Lines • Show All 351 Lines • ▼ Show 20 Lines
; CHECK-NEXT: [[C:%.*]] = sub i8 16, [[A:%.*]] ; CHECK-NEXT: [[C:%.*]] = sub i8 16, [[A:%.*]]
; CHECK-NEXT: ret i8 [[C]] ; CHECK-NEXT: ret i8 [[C]]
; ;
%B = xor i8 %A, -1 %B = xor i8 %A, -1
%C = add i8 %B, 17 %C = add i8 %B, 17
ret i8 %C ret i8 %C
} }
; ~X + -127 and (-128) - X with nsw are equally poisonous
define i8 @test18_nsw(i8 %A) {
; CHECK-LABEL: @test18_nsw(
; CHECK-NEXT: [[C:%.*]] = sub i8 -128, [[A:%.*]]
; CHECK-NEXT: ret i8 [[C]]
;
%B = xor i8 %A, -1
%C = add nsw i8 %B, -127
ret i8 %C
}
; nuw couldn't propagate as nsw is.
define i8 @test18_nuw(i8 %A) {
; CHECK-LABEL: @test18_nuw(
; CHECK-NEXT: [[C:%.*]] = sub i8 -128, [[A:%.*]]
; CHECK-NEXT: ret i8 [[C]]
;
%B = xor i8 %A, -1
%C = add nuw i8 %B, -127
ret i8 %C
}
; 127 - X with nsw will be more poisonous than ~X + -128 with nsw. (see X = -1)
define i8 @test18_nsw_overflow(i8 %A) {
; CHECK-LABEL: @test18_nsw_overflow(
; CHECK-NEXT: [[C:%.*]] = sub i8 127, [[A:%.*]]
; CHECK-NEXT: ret i8 [[C]]
;
%B = xor i8 %A, -1
%C = add nsw i8 %B, -128
ret i8 %C
}
define <2 x i64> @test18vec(<2 x i64> %A) { define <2 x i64> @test18vec(<2 x i64> %A) {
; CHECK-LABEL: @test18vec( ; CHECK-LABEL: @test18vec(
; CHECK-NEXT: [[ADD:%.*]] = sub <2 x i64> <i64 1, i64 2>, [[A:%.*]] ; CHECK-NEXT: [[ADD:%.*]] = sub <2 x i64> <i64 1, i64 2>, [[A:%.*]]
; CHECK-NEXT: ret <2 x i64> [[ADD]] ; CHECK-NEXT: ret <2 x i64> [[ADD]]
; ;
%xor = xor <2 x i64> %A, <i64 -1, i64 -1> %xor = xor <2 x i64> %A, <i64 -1, i64 -1>
%add = add <2 x i64> %xor, <i64 2, i64 3> %add = add <2 x i64> %xor, <i64 2, i64 3>
ret <2 x i64> %add ret <2 x i64> %add
} }
define <2 x i8> @test18vec_nsw(<2 x i8> %A) {
; CHECK-LABEL: @test18vec_nsw(
; CHECK-NEXT: [[C:%.*]] = sub <2 x i8> <i8 -124, i8 -125>, [[A:%.*]]
; CHECK-NEXT: ret <2 x i8> [[C]]
;
%B = xor <2 x i8> %A, <i8 -1, i8 -1>
%C = add nsw <2 x i8> %B, <i8 -123, i8 -124>
ret <2 x i8> %C
}
; TODO: fix ValueTracking overflow check for non-splat vector, could be attached nsw
; this shouldn't overflow.
define <2 x i8> @test18vec_nsw_false(<2 x i8> %A) {
; CHECK-LABEL: @test18vec_nsw_false(
; CHECK-NEXT: [[C:%.*]] = sub <2 x i8> <i8 -125, i8 -126>, [[A:%.*]]
; CHECK-NEXT: ret <2 x i8> [[C]]
;
%B = xor <2 x i8> %A, <i8 -1, i8 -1>
%C = add nsw <2 x i8> %B, <i8 -124, i8 -125>
ret <2 x i8> %C
}
define <2 x i8> @test18vec_nuw(<2 x i8> %A) {
; CHECK-LABEL: @test18vec_nuw(
; CHECK-NEXT: [[C:%.*]] = sub <2 x i8> <i8 -128, i8 -127>, [[A:%.*]]
; CHECK-NEXT: ret <2 x i8> [[C]]
;
%B = xor <2 x i8> %A, <i8 -1, i8 -1>
%C = add nuw <2 x i8> %B, <i8 -127, i8 -126>
ret <2 x i8> %C
}
define <2 x i8> @test18vec_nsw_overflow(<2 x i8> %A) {
; CHECK-LABEL: @test18vec_nsw_overflow(
; CHECK-NEXT: [[C:%.*]] = sub <2 x i8> <i8 -128, i8 127>, [[A:%.*]]
; CHECK-NEXT: ret <2 x i8> [[C]]
;
%B = xor <2 x i8> %A, <i8 -1, i8 -1>
%C = add nsw <2 x i8> %B, <i8 -127, i8 -128>
ret <2 x i8> %C
}
define i32 @test19(i1 %C) { define i32 @test19(i1 %C) {
; CHECK-LABEL: @test19( ; CHECK-LABEL: @test19(
; CHECK-NEXT: [[V:%.*]] = select i1 [[C:%.*]], i32 1123, i32 133 ; CHECK-NEXT: [[V:%.*]] = select i1 [[C:%.*]], i32 1123, i32 133
; CHECK-NEXT: ret i32 [[V]] ; CHECK-NEXT: ret i32 [[V]]
; ;
%A = select i1 %C, i32 1000, i32 10 %A = select i1 %C, i32 1000, i32 10
%V = add i32 %A, 123 %V = add i32 %A, 123
ret i32 %V ret i32 %V
▲ Show 20 Lines • Show All 2,569 Lines • Show Last 20 Lines