This is an archive of the discontinued LLVM Phabricator instance.

Differential D152087

[AVR][NFC][test] Supplement a test of pseudo instruction RORBRd
ClosedPublic

Authored by benshi001 on Jun 3 2023, 8:26 PM.

Download Raw Diff

Details

Reviewers

aykevl
Patryk27
jacquesguan
Miss_Grape

Commits

rG53a7c254e493: [AVR][NFC][test] Suppement a test of the pseudo instruction RORBRd

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

benshi001 created this revision.Jun 3 2023, 8:26 PM

Herald added a project: Restricted Project. · View Herald TranscriptJun 3 2023, 8:26 PM

Herald added subscribers: Jim, dylanmckay. · View Herald Transcript

benshi001 requested review of this revision.Jun 3 2023, 8:26 PM

Herald added a project: Restricted Project. · View Herald TranscriptJun 3 2023, 8:26 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

benshi001 retitled this revision from [AVR] Supplement a test of the pseudo instruction RORBRd to [AVR][NFC][test] Supplement a test of pseudo instruction RORBRd.Jun 3 2023, 8:28 PM

Harbormaster completed remote builds in B236430: Diff 528176.Jun 3 2023, 9:00 PM

Patryk27 accepted this revision.Jun 4 2023, 2:00 AM

This revision is now accepted and ready to land.Jun 4 2023, 2:00 AM

aykevl accepted this revision.Jun 4 2023, 6:34 AM

aykevl added inline comments.

llvm/test/CodeGen/AVR/pseudo/RORBrd.mir
23	The only possible improvement I can think of is using CHECK-NEXT but it's fine as-is.

benshi001 marked an inline comment as done.Jun 4 2023, 7:44 AM

benshi001 added inline comments.

llvm/test/CodeGen/AVR/pseudo/RORBrd.mir
23	Thanks. I will fix this when committing it.

Closed by commit rG53a7c254e493: [AVR][NFC][test] Suppement a test of the pseudo instruction RORBRd (authored by benshi001). · Explain WhyJun 4 2023, 8:19 AM

This revision was automatically updated to reflect the committed changes.

benshi001 marked an inline comment as done.

benshi001 added a commit: rG53a7c254e493: [AVR][NFC][test] Suppement a test of the pseudo instruction RORBRd.

Revision Contents

Path

Size

llvm/

test/

CodeGen/

AVR/

pseudo/

RORBrd.mir

25 lines

Diff 528218

llvm/test/CodeGen/AVR/pseudo/RORBrd.mir

This file was added.

				# RUN: llc -O0 -run-pass=avr-expand-pseudo %s -o - \| FileCheck %s

				# This test checks the expansion of the 8-bit RORB (rotate) pseudo instruction.

				--- \|
				target triple = "avr--"
				define void @test_rorbrd() {
				entry:
				ret void
				}
				...

				---
				name: test_rorbrd
				body: \|
				bb.0.entry:
				liveins: $r14

				; CHECK-LABEL: test_rorbrd
				; CHECK: BST $r14, 0, implicit-def $sreg
				; CHECK-NEXT: $r14 = RORRd $r14, implicit-def $sreg, implicit $sreg
				; CHECK-NEXT: $r14 = BLD $r14, 7, implicit $sreg

				aykevlUnsubmitted Done Reply Inline Actions The only possible improvement I can think of is using CHECK-NEXT but it's fine as-is. aykevl: The only possible improvement I can think of is using CHECK-NEXT but it's fine as-is.
				benshi001AuthorUnsubmitted Done Reply Inline Actions Thanks. I will fix this when committing it. benshi001: Thanks. I will fix this when committing it.
				$r14 = RORBRd $r14, implicit-def $sreg
				...