Page MenuHomePhabricator

Patryk27 (Patryk Wychowaniec)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 22 2021, 10:34 AM (52 w, 5 d)

Recent Activity

Jun 26 2022

Patryk27 added inline comments to D128588: [AVR] Fix expanding MOVW for overlapping registers.
Jun 26 2022, 1:11 AM · Restricted Project, Restricted Project
Patryk27 updated the diff for D128588: [AVR] Fix expanding MOVW for overlapping registers.

Apply code review changes

Jun 26 2022, 1:10 AM · Restricted Project, Restricted Project
Patryk27 abandoned D128602: Apply code review suggestions.

Whoopsie, I meant to update the already-existing diff - let me close this one.

Jun 26 2022, 1:09 AM · Restricted Project, Restricted Project
Patryk27 requested review of D128602: Apply code review suggestions.
Jun 26 2022, 1:08 AM · Restricted Project, Restricted Project

Jun 25 2022

Patryk27 added a reviewer for D128588: [AVR] Fix expanding MOVW for overlapping registers: benshi001.
Jun 25 2022, 10:27 AM · Restricted Project, Restricted Project
Patryk27 requested review of D128588: [AVR] Fix expanding MOVW for overlapping registers.
Jun 25 2022, 10:24 AM · Restricted Project, Restricted Project

May 9 2022

Patryk27 abandoned D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2.

Changes in this revision were split into separate revisions, so this one is not needed anymore.

May 9 2022, 1:25 AM · Restricted Project, Restricted Project, Restricted Project

May 8 2022

Patryk27 accepted D124913: [AVR] Add PrintMethod for operand memspi.

The TableGen stuff is still dark magic to me, but the change looks easy & reasonable :-)

May 8 2022, 11:44 PM · Restricted Project, Restricted Project

May 5 2022

Patryk27 accepted D125066: [AVR][NFC] Eliminate warning 'unused variable'.
May 5 2022, 11:13 PM · Restricted Project, Restricted Project
Patryk27 added inline comments to D125066: [AVR][NFC] Eliminate warning 'unused variable'.
May 5 2022, 10:55 PM · Restricted Project, Restricted Project

May 4 2022

Patryk27 added a comment to D123528: [AVR] Always expand STDSPQRr & STDWSPQRr.

Thanks for the review - I've applied all the changes :-)

May 4 2022, 9:59 AM · Restricted Project, Restricted Project
Patryk27 updated the diff for D123528: [AVR] Always expand STDSPQRr & STDWSPQRr.

Applying code review comments

May 4 2022, 9:54 AM · Restricted Project, Restricted Project

Apr 21 2022

Patryk27 updated the diff for D123528: [AVR] Always expand STDSPQRr & STDWSPQRr.

Rebase

Apr 21 2022, 8:58 AM · Restricted Project, Restricted Project

Apr 11 2022

Patryk27 updated subscribers of D123528: [AVR] Always expand STDSPQRr & STDWSPQRr.

So far I've just moved appropriate parts of code from the previous merge request (https://reviews.llvm.org/D114611), but I haven't yet applied 3.2 & 3.3 from https://reviews.llvm.org/D114611#3394757, since I don't quite understand those suggestions - currently the expansion uses either the Y _or_ the X register, and it looks like you'd rather for that instruction to always rely on X?

Apr 11 2022, 11:15 AM · Restricted Project, Restricted Project
Patryk27 requested review of D123528: [AVR] Always expand STDSPQRr & STDWSPQRr.
Apr 11 2022, 11:13 AM · Restricted Project, Restricted Project

Mar 27 2022

Patryk27 added a comment to D122533: [AVR] Remove AVRRelaxMemOperations.

Ok, I have added the switch; I think a separate patch that adds that switch to all of the AVR tests could come handy - what do you think?

No. -verify-machineinstrs might be default in the future, which is still under discuss, since it costs longer time. Currently we just make highly risky case with explicit -verify-machineinstrs, such as yours. ^_^

Mar 27 2022, 10:51 PM · Restricted Project, Restricted Project, Restricted Project
Patryk27 added a comment to D122533: [AVR] Remove AVRRelaxMemOperations.

Ok, I have added the switch; I think a separate patch that adds that switch to all of the AVR tests could come handy - what do you think?

Mar 27 2022, 10:56 AM · Restricted Project, Restricted Project, Restricted Project
Patryk27 updated the diff for D122533: [AVR] Remove AVRRelaxMemOperations.

Add -verify-machineinstrs

Mar 27 2022, 10:54 AM · Restricted Project, Restricted Project, Restricted Project
Patryk27 added a comment to D122533: [AVR] Remove AVRRelaxMemOperations.

Ah, nevermind - looks like I've already actually used SUBIWRdK.

Mar 27 2022, 5:43 AM · Restricted Project, Restricted Project, Restricted Project
Patryk27 added a comment to D122533: [AVR] Remove AVRRelaxMemOperations.

Ah, sorry - I've pushed my changes at the same time you created your comment; one moment, let me change to SUBIW, then.

Mar 27 2022, 5:42 AM · Restricted Project, Restricted Project, Restricted Project
Patryk27 added inline comments to D122533: [AVR] Remove AVRRelaxMemOperations.
Mar 27 2022, 5:41 AM · Restricted Project, Restricted Project, Restricted Project
Patryk27 updated the diff for D122533: [AVR] Remove AVRRelaxMemOperations.

SBCI -> SUBI

Mar 27 2022, 5:40 AM · Restricted Project, Restricted Project, Restricted Project
Patryk27 added a comment to D122533: [AVR] Remove AVRRelaxMemOperations.

I think I'm using =Release instead of =Debug, that would explain the difference, yeah;

Mar 27 2022, 5:09 AM · Restricted Project, Restricted Project, Restricted Project
Patryk27 added inline comments to D122533: [AVR] Remove AVRRelaxMemOperations.
Mar 27 2022, 5:08 AM · Restricted Project, Restricted Project, Restricted Project
Patryk27 added a comment to D122533: [AVR] Remove AVRRelaxMemOperations.

Hmm, that's weird - I've just re-checked and everything's working correctly on my side; maybe you're testing it on an older LLVM revision? (for reference, my patch is based off of the current LLVM's main branch, which - at the time of writing this comment - is the d9cea8d3a8fff86672174780312674871729578c commit).

Mar 27 2022, 4:15 AM · Restricted Project, Restricted Project, Restricted Project

Mar 26 2022

Patryk27 added a comment to D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2.

Thanks for the review!

Mar 26 2022, 12:57 PM · Restricted Project, Restricted Project, Restricted Project
Patryk27 updated subscribers of D122533: [AVR] Remove AVRRelaxMemOperations.

cc @benshi001 (from https://reviews.llvm.org/D114611) 🙂

Mar 26 2022, 12:56 PM · Restricted Project, Restricted Project, Restricted Project
Patryk27 updated the diff for D122533: [AVR] Remove AVRRelaxMemOperations.

avr -> AVR

Mar 26 2022, 12:53 PM · Restricted Project, Restricted Project, Restricted Project
Patryk27 requested review of D122533: [AVR] Remove AVRRelaxMemOperations.
Mar 26 2022, 12:52 PM · Restricted Project, Restricted Project, Restricted Project

Jan 22 2022

Patryk27 updated the diff for D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2.
Jan 22 2022, 6:49 AM · Restricted Project, Restricted Project, Restricted Project
Patryk27 added inline comments to D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2.
Jan 22 2022, 4:47 AM · Restricted Project, Restricted Project, Restricted Project
Patryk27 updated the diff for D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2.
Jan 22 2022, 4:45 AM · Restricted Project, Restricted Project, Restricted Project

Jan 18 2022

Patryk27 added a comment to D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2.

I've just found a small bug with our current approach: if we generate STDWPtrQRr from within AVRExpandPseudo, then we don't have a chance to run AVRRelaxMem on that newly-created instruction (so, bottom line, functions with larger stacks trigger assert(Imm <= 62 && "Offset is out of range");).

Jan 18 2022, 2:50 AM · Restricted Project, Restricted Project, Restricted Project

Dec 18 2021

Patryk27 added a comment to D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2.

I've got some progress!

Dec 18 2021, 3:32 AM · Restricted Project, Restricted Project, Restricted Project

Dec 17 2021

Patryk27 added a comment to D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2.

Edit: this is a wrong lead; please see: https://reviews.llvm.org/D114611#3201290.

Dec 17 2021, 11:52 AM · Restricted Project, Restricted Project, Restricted Project

Dec 15 2021

Patryk27 added inline comments to D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2.
Dec 15 2021, 11:09 PM · Restricted Project, Restricted Project, Restricted Project
Patryk27 added inline comments to D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2.
Dec 15 2021, 11:08 PM · Restricted Project, Restricted Project, Restricted Project
Patryk27 added inline comments to D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2.
Dec 15 2021, 11:32 AM · Restricted Project, Restricted Project, Restricted Project

Dec 12 2021

Patryk27 added inline comments to D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2.
Dec 12 2021, 9:12 AM · Restricted Project, Restricted Project, Restricted Project

Dec 4 2021

Patryk27 updated the diff for D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2.
Dec 4 2021, 9:40 AM · Restricted Project, Restricted Project, Restricted Project

Dec 1 2021

Patryk27 added inline comments to D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2.
Dec 1 2021, 11:17 AM · Restricted Project, Restricted Project, Restricted Project
Patryk27 added a comment to D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2.

Thanks for the review! Seizing the day, I've moved all of the regression tests to a common directory called regression - I think it's a bit tidier this way 🙂

Dec 1 2021, 11:14 AM · Restricted Project, Restricted Project, Restricted Project
Patryk27 updated the diff for D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2.
Dec 1 2021, 11:12 AM · Restricted Project, Restricted Project, Restricted Project

Nov 29 2021

Patryk27 added inline comments to D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2.
Nov 29 2021, 4:43 AM · Restricted Project, Restricted Project, Restricted Project

Nov 28 2021

Patryk27 updated the diff for D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2.
Nov 28 2021, 11:23 AM · Restricted Project, Restricted Project, Restricted Project

Nov 25 2021

Patryk27 added inline comments to D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2.
Nov 25 2021, 1:22 PM · Restricted Project, Restricted Project, Restricted Project
Patryk27 added inline comments to D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2.
Nov 25 2021, 1:15 PM · Restricted Project, Restricted Project, Restricted Project
Patryk27 updated the summary of D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2.
Nov 25 2021, 1:12 PM · Restricted Project, Restricted Project, Restricted Project
Patryk27 requested review of D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2.
Nov 25 2021, 1:12 PM · Restricted Project, Restricted Project, Restricted Project