- User Since
- Nov 22 2021, 10:34 AM (52 w, 5 d)
Jun 26 2022
Apply code review changes
Whoopsie, I meant to update the already-existing diff - let me close this one.
Jun 25 2022
May 9 2022
Changes in this revision were split into separate revisions, so this one is not needed anymore.
May 8 2022
The TableGen stuff is still dark magic to me, but the change looks easy & reasonable :-)
May 5 2022
May 4 2022
Thanks for the review - I've applied all the changes :-)
Applying code review comments
Apr 21 2022
Apr 11 2022
So far I've just moved appropriate parts of code from the previous merge request (https://reviews.llvm.org/D114611), but I haven't yet applied 3.2 & 3.3 from https://reviews.llvm.org/D114611#3394757, since I don't quite understand those suggestions - currently the expansion uses either the Y _or_ the X register, and it looks like you'd rather for that instruction to always rely on X?
Mar 27 2022
Ok, I have added the switch; I think a separate patch that adds that switch to all of the AVR tests could come handy - what do you think?
Ah, nevermind - looks like I've already actually used SUBIWRdK.
Ah, sorry - I've pushed my changes at the same time you created your comment; one moment, let me change to SUBIW, then.
SBCI -> SUBI
I think I'm using =Release instead of =Debug, that would explain the difference, yeah;
Hmm, that's weird - I've just re-checked and everything's working correctly on my side; maybe you're testing it on an older LLVM revision? (for reference, my patch is based off of the current LLVM's main branch, which - at the time of writing this comment - is the d9cea8d3a8fff86672174780312674871729578c commit).
Mar 26 2022
Thanks for the review!
avr -> AVR
Jan 22 2022
Jan 18 2022
I've just found a small bug with our current approach: if we generate STDWPtrQRr from within AVRExpandPseudo, then we don't have a chance to run AVRRelaxMem on that newly-created instruction (so, bottom line, functions with larger stacks trigger assert(Imm <= 62 && "Offset is out of range");).
Dec 18 2021
I've got some progress!
Dec 17 2021
Edit: this is a wrong lead; please see: https://reviews.llvm.org/D114611#3201290.
Dec 15 2021
Dec 12 2021
Dec 4 2021
Dec 1 2021
Thanks for the review! Seizing the day, I've moved all of the regression tests to a common directory called regression - I think it's a bit tidier this way 🙂