CI: run "apt update" once per job before installing packages

[charlesthobe]

Summary

Fixes failure of "Release Binaries" github workflow run.

[tstellar]

LGTM. Thank You.

[charlesthobe]

there's a double sudo, one second while I fix it.

[charlesthobe]

removed double "sudo"

[tstellar]

In D152064#4392956, @charlesthobe wrote:

removed double "sudo"

LGTM.

[charlesthobe]

In D152064#4392949, @tstellar wrote:

LGTM. Thank You.

You're welcome 😄

[tstellar]

Do you need me to commit this for you? If so, what name and email should I use for the commit author?

[charlesthobe]

In D152064#4392960, @tstellar wrote:

Do you need me to commit this for you? If so, what name and email should I use for the commit author?

username: charlesthobe
name: Charles the Thobe
my email is: [e-mail]

[charlesthobe]

commit message should be:

CI: run "apt update" once per job before installing packages

imo

[charlesthobe]

One second please I have an improvement to make

[charlesthobe]

Use "apt update" before "llvm/actions/install-ninja" which uses "apt install" without "apt update" beforehand
Apt update is now its own step for ease of readability and a less hacky looking solution with running it within the first step which installs packages

[charlesthobe]

I apologize for the too many revisions, and that the initial patch wasn't in a production ready state, but it's now ready for merging, I believe.

[charlesthobe]

.github/workflows/release-binaries.yml

65

Comment on the original behavior:
The matrix only has one element in the "runs-on" array which is "ubuntu-22.04-8x32" so a check for the runner OS or the value of the array element isn't needed, also the check is absent from other checks, if in the future this matrix array is going to be expanded then checks are gonna have to be added.

85

Comment on the original behavior:
This condition is never met.

[charlesthobe]

.github/workflows/release-binaries.yml

65

Comment on the original behavior:
The matrix only has one element in the "runs-on" array which is "ubuntu-22.04-8x32" so a check for the runner OS or the value of the array element isn't needed, also the check is absent from other steps, if in the future this matrix array is going to be expanded then checks are gonna have to be added.

[charlesthobe]

these were just comments on why I don't have a check for ubuntu in this area, nothing needs to be done.

[charlesthobe]

I think this is ready for review unless you see problems in it?

.github/workflows/libclang-abi-tests.yml

strategy:
             llvm_version_major: ${{ needs.abi-dump-setup.outputs.LLVM_VERSION_MAJOR }}
             ref: ${{ github.sha }}
             repo: ${{ github.repository }}
     steps:
       - name: Install Ninja
         uses: llvm/actions/install-ninja@main
       - name: Install abi-compliance-checker
         run: |
-          sudo apt-get install abi-dumper autoconf pkg-config
+          sudo apt update
+          sudo apt install abi-dumper autoconf pkg-config
       - name: Install universal-ctags
         run: |
           git clone https://github.com/universal-ctags/ctags.git
           cd ctags
           ./autogen.sh
           ./configure
           sudo make install
       - name: Download source code
steps:
         with:
           name: build-baseline
       - name: Download latest
         uses: actions/download-artifact@v3
         with:
           name: build-latest
 
       - name: Install abi-compliance-checker
-        run: sudo apt-get install abi-compliance-checker
+        run: |
+          sudo apt update
+          sudo apt install abi-compliance-checker
       - name: Compare ABI
         run: |
           for lib in ${{ needs.abi-dump-setup.outputs.ABI_LIBS }}; do
             abi-compliance-checker -lib $lib -old build-baseline/$lib*.abi -new build-latest/$lib*.abi
           done
       - name: Upload ABI Comparison
         if: always()
         uses: actions/upload-artifact@v3
         with:
           name: compat-report-${{ github.sha }}
           path: compat_reports/

.github/workflows/llvm-tests.yml

strategy:
             llvm_version_major: ${{ needs.abi-dump-setup.outputs.LLVM_VERSION_MAJOR }}
             ref: ${{ github.sha }}
             repo: ${{ github.repository }}
     steps:
       - name: Install Ninja
         uses: llvm/actions/install-ninja@main
       - name: Install abi-compliance-checker
         run: |
-          sudo apt-get install abi-dumper autoconf pkg-config
+          sudo apt update
+          sudo apt install abi-dumper autoconf pkg-config
       - name: Install universal-ctags
         run: |
           git clone https://github.com/universal-ctags/ctags.git
           cd ctags
           ./autogen.sh
           ./configure
           sudo make install
       - name: Download source code
steps:
         with:
           name: build-latest
       - name: Download symbol list
         uses: actions/download-artifact@v3
         with:
           name: symbol-list
 
       - name: Install abi-compliance-checker
-        run: sudo apt-get install abi-compliance-checker
+        run: |
+          sudo apt update
+          sudo apt install abi-compliance-checker
       - name: Compare ABI
         run: |
           if [ -s symbol-list/llvm.symbols ]; then
             # This option doesn't seem to work with the ABI dumper, so passing it here.
             export EXTRA_ARGS="-symbols-list symbol-list/llvm.symbols"
           fi
           # FIXME: Reading of gzip'd abi files on the GitHub runners stop
           # working some time in March of 2021, likely due to a change in the
           # runner's environment.
           abi-compliance-checker $EXTRA_ARGS -l libLLVM.so -old build-baseline/*.abi -new build-latest/*.abi || test "${{ needs.abi-dump-setup.outputs.ABI_HEADERS }}" = "llvm-c"
       - name: Upload ABI Comparison
         if: always()
         uses: actions/upload-artifact@v3
         with:
           name: compat-report-${{ github.sha }}
           path: compat_reports/

.github/workflows/release-binaries.yml

- name: Validate and parse tag
         fi
         bash .github/workflows/set-release-binary-outputs.sh "${{ github.actor }}" "$tag" "$upload"
 
   build-binaries:
     name: ${{ matrix.target.triple }}
     permissions:
       contents: write # To upload assets to release.
     needs: prepare
     runs-on: ${{ matrix.target.runs-on }}
     strategy:
       fail-fast: false
       matrix:
         target:
           - triple: x86_64-linux-gnu-ubuntu-22.04
             runs-on: ubuntu-22.04-8x32
             debian-build-deps: >
               chrpath
               gcc-multilib
               ninja-build
 
     steps:
     - name: Checkout LLVM
       uses: actions/checkout@v3
       with:
         ref: ${{ needs.prepare.outputs.ref }}
         path: ${{ needs.prepare.outputs.build-dir }}/llvm-project
 
     - name: Install Brew build dependencies
       if: matrix.target.brew-build-deps != ''
       run: brew install ${{ matrix.target.brew-build-deps }}
 
     - name: Install Debian build dependencies
       if: matrix.target.debian-build-deps != ''
-      run: sudo apt install ${{ matrix.target.debian-build-deps }}
+      run: |
+        sudo apt update
+        sudo apt install ${{ matrix.target.debian-build-deps }}
 
     - name: Set macOS build env variables
       if: runner.os == 'macOS'
       run: |
         echo "MACOSX_DEPLOYMENT_TARGET=10.9" >> $GITHUB_ENV
 
     - name: Build and test release
       run: |
         ${{ needs.prepare.outputs.build-dir }}/llvm-project/llvm/utils/release/test-release.sh \
         -release ${{ needs.prepare.outputs.release }} \
         ${{ needs.prepare.outputs.rc-flags }} \
         -triple ${{ matrix.target.triple }} \
         -use-ninja \
         -no-checkout \
         -no-test-suite
 
     - name: Upload binaries
       if: ${{ always() && needs.prepare.outputs.upload == 'true' }}
       run: |
-        sudo apt install python3-github
+        sudo sudo apt install python3-github
         ${{ needs.prepare.outputs.build-dir }}/llvm-project/llvm/utils/release/github-upload-release.py \
         --token ${{ github.token }} \
         --release ${{ needs.prepare.outputs.release-version }} \
         upload \
         --files ${{ needs.prepare.outputs.build-dir }}/clang+llvm-${{ needs.prepare.outputs.release-version }}-${{ matrix.target.triple }}.tar.xz

.github/workflows/release-tasks.yml

steps:
         run: |
           test "${{ github.actor }}" = "tstellar" || test "${{ github.actor }}" = "tru"
           echo "${{ github.ref_name }}" | grep -e '^llvmorg-[0-9]\+\.[0-9]\+\.[0-9]\+\(-rc[0-9]\+\)\?$'
           release_version=$(echo "${{ github.ref_name }}" | sed 's/llvmorg-//g')
           echo "release-version=$release_version" >> $GITHUB_OUTPUT
 
       - name: Install Dependencies
         run: |
-          sudo apt-get update
-          sudo apt-get install -y \
+          sudo apt update
+          sudo apt install -y \
               doxygen \
               graphviz \
               python3-github \
               python3-recommonmark \
               python3-sphinx \
               ninja-build \
               texlive-font-utils
           pip3 install --user sphinx-markdown-tables
jobs:
   release-lit:
     runs-on: ubuntu-latest
     if: github.repository == 'llvm/llvm-project'
     steps:
       - name: Checkout LLVM
         uses: actions/checkout@v3
 
       - name: Install dependencies
-        run: apt-get install -y python3-setuptools
+        run: |
+          sudo apt update
+          sudo apt install -y python3-setuptools
 
       - name: Test lit
         run: |
           cd llvm/utils/lit
           python3 lit.py tests
 
       - name: Package lit
         run: |