Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

charlesthobe (Charles the Thobe)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 3 2023, 6:16 AM (16 w, 5 d)

Recent Activity

Jun 7 2023

charlesthobe added a comment to D152064: CI: run "apt update" once per job before installing packages.

I think this is ready for review unless you see problems in it?

Jun 7 2023, 9:59 AM · Restricted Project, Restricted Project

Jun 4 2023

charlesthobe added a comment to D152064: CI: run "apt update" once per job before installing packages.

these were just comments on why I don't have a check for ubuntu in this area, nothing needs to be done.

Jun 4 2023, 5:38 AM · Restricted Project, Restricted Project
charlesthobe added inline comments to D152064: CI: run "apt update" once per job before installing packages.
Jun 4 2023, 4:13 AM · Restricted Project, Restricted Project
charlesthobe added inline comments to D152064: CI: run "apt update" once per job before installing packages.
Jun 4 2023, 4:10 AM · Restricted Project, Restricted Project
charlesthobe added a comment to D152064: CI: run "apt update" once per job before installing packages.

I apologize for the too many revisions, and that the initial patch wasn't in a production ready state, but it's now ready for merging, I believe.

Jun 4 2023, 3:10 AM · Restricted Project, Restricted Project

Jun 3 2023

charlesthobe updated the diff for D152064: CI: run "apt update" once per job before installing packages.
Jun 3 2023, 7:24 PM · Restricted Project, Restricted Project
charlesthobe updated the diff for D152064: CI: run "apt update" once per job before installing packages.
Jun 3 2023, 7:03 PM · Restricted Project, Restricted Project
charlesthobe updated the diff for D152064: CI: run "apt update" once per job before installing packages.
Jun 3 2023, 10:59 AM · Restricted Project, Restricted Project
charlesthobe updated the diff for D152064: CI: run "apt update" once per job before installing packages.

Use "apt update" before "llvm/actions/install-ninja" which uses "apt install" without "apt update" beforehand
Apt update is now its own step for ease of readability and a less hacky looking solution with running it within the first step which installs packages

Jun 3 2023, 10:32 AM · Restricted Project, Restricted Project
charlesthobe added a comment to D152064: CI: run "apt update" once per job before installing packages.

One second please I have an improvement to make

Jun 3 2023, 10:12 AM · Restricted Project, Restricted Project
charlesthobe retitled D152064: CI: run "apt update" once per job before installing packages from CI: run "apt update" before installing any packages to CI: run "apt update" once per job before installing packages.
Jun 3 2023, 8:33 AM · Restricted Project, Restricted Project
charlesthobe added a comment to D152064: CI: run "apt update" once per job before installing packages.

commit message should be:

CI: run "apt update" once per job before installing packages

imo

Jun 3 2023, 7:16 AM · Restricted Project, Restricted Project
charlesthobe added a comment to D152064: CI: run "apt update" once per job before installing packages.

Do you need me to commit this for you? If so, what name and email should I use for the commit author?

Jun 3 2023, 7:03 AM · Restricted Project, Restricted Project
charlesthobe added a comment to D152064: CI: run "apt update" once per job before installing packages.

LGTM. Thank You.

Jun 3 2023, 6:55 AM · Restricted Project, Restricted Project
charlesthobe updated the diff for D152064: CI: run "apt update" once per job before installing packages.

removed double "sudo"

Jun 3 2023, 6:53 AM · Restricted Project, Restricted Project
charlesthobe added a comment to D152064: CI: run "apt update" once per job before installing packages.

there's a double sudo, one second while I fix it.

Jun 3 2023, 6:49 AM · Restricted Project, Restricted Project
charlesthobe requested review of D152064: CI: run "apt update" once per job before installing packages.
Jun 3 2023, 6:47 AM · Restricted Project, Restricted Project