CI: run "apt update" once per job before installing packages

[charlesthobe]

Summary

Fixes failure of "Release Binaries" github workflow run.

[tstellar]

LGTM. Thank You.

[charlesthobe]

there's a double sudo, one second while I fix it.

[charlesthobe]

removed double "sudo"

[tstellar]

In D152064#4392956, @charlesthobe wrote:

removed double "sudo"

LGTM.

[charlesthobe]

In D152064#4392949, @tstellar wrote:

LGTM. Thank You.

You're welcome 😄

[tstellar]

Do you need me to commit this for you? If so, what name and email should I use for the commit author?

[charlesthobe]

In D152064#4392960, @tstellar wrote:

Do you need me to commit this for you? If so, what name and email should I use for the commit author?

username: charlesthobe
name: Charles the Thobe
my email is: [e-mail]

[charlesthobe]

commit message should be:

CI: run "apt update" once per job before installing packages

imo

[charlesthobe]

One second please I have an improvement to make

[charlesthobe]

Use "apt update" before "llvm/actions/install-ninja" which uses "apt install" without "apt update" beforehand
Apt update is now its own step for ease of readability and a less hacky looking solution with running it within the first step which installs packages

[charlesthobe]

I apologize for the too many revisions, and that the initial patch wasn't in a production ready state, but it's now ready for merging, I believe.

[charlesthobe]

.github/workflows/release-binaries.yml

65

Comment on the original behavior:
The matrix only has one element in the "runs-on" array which is "ubuntu-22.04-8x32" so a check for the runner OS or the value of the array element isn't needed, also the check is absent from other checks, if in the future this matrix array is going to be expanded then checks are gonna have to be added.

85

Comment on the original behavior:
This condition is never met.

[charlesthobe]

.github/workflows/release-binaries.yml

65

Comment on the original behavior:
The matrix only has one element in the "runs-on" array which is "ubuntu-22.04-8x32" so a check for the runner OS or the value of the array element isn't needed, also the check is absent from other steps, if in the future this matrix array is going to be expanded then checks are gonna have to be added.

[charlesthobe]

these were just comments on why I don't have a check for ubuntu in this area, nothing needs to be done.

[charlesthobe]

I think this is ready for review unless you see problems in it?