Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D152061

[clang] fix TranslateXarchArgs to support -Xarch_device -O*
Needs ReviewPublic
Actions

Authored by chenguang on Jun 3 2023, 4:31 AM.

Details

Reviewers

yaxunl
awarzynski

Summary

Origin code: when passed -Xarch_device -O1, TranslateXarchArgs will parse -O1 as a CLFlag, which has flags NoXarchOption , and then report error. Now: TranslateXarchArgs parse -O1 as O_Group

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	130 ms	x64 debian > Clang.Driver::Xarch.c
	100 ms	x64 debian > Clang.Driver::driver-only.c
	530 ms	x64 debian > Clang.Driver::hip-options.hip

Event Timeline

chenguang created this revision.Jun 3 2023, 4:31 AM

Herald added a project: Restricted Project. · View Herald TranscriptJun 3 2023, 4:31 AM

chenguang requested review of this revision.Jun 3 2023, 4:31 AM

Herald added a project: Restricted Project. · View Herald TranscriptJun 3 2023, 4:31 AM

Herald added subscribers: cfe-commits, MaskRay. · View Herald Transcript

chenguang retitled this revision from [clang] fix TranslateXarchArgs to support -Xarch_device -O* Origin code: when passed -Xarch_device -O1, TranslateXarchArgs will parse -O1 as a CLFlag, which has flags NoXarchOption , and then report error. Now: TranslateXarchArgs parse -O1 as O_Group to [clang] fix TranslateXarchArgs to support -Xarch_device -O* .Jun 3 2023, 4:34 AM

chenguang edited the summary of this revision. (Show Details)

chenguang added reviewers: yaxunl, awarzynski.

Harbormaster completed remote builds in B236361: Diff 528095.Jun 3 2023, 5:09 AM