[lldb/crashlog] Expand crash report file path before parsing

[mib]

Summary

This patch should fix a crash in the opening a crash report that was
passed with a relative path.

This patch expands the crash report path before parsing it and raises a
FileNotFoundError exception if the file doesn't exist.

Signed-off-by: Med Ismail Bennani <[e-mail]>

[bulbazord]

The key here is that you're expanding the path and checking for the validity before calling CrashLogParser.create() right? It looks like for the load_crashlog_in_scripted_process case nothing has changed. If my understanding is correct, then this looks good to me.

[mib]

In D152012#4391336, @bulbazord wrote:

The key here is that you're expanding the path and checking for the validity before calling CrashLogParser.create() right? It looks like for the load_crashlog_in_scripted_process case nothing has changed. If my understanding is correct, then this looks good to me.

Yep, I had to fixed this in the past for interactive mode in a07a751 but not for the regular crashlog command. This patch refactors it to cover both cases.

lldb/examples/python/crashlog.py

for thread in crash_log.threads:
         print()
 
     if crash_log.errors:
         print("Errors:")
         for error in crash_log.errors:
             print(error)
 
 
-def load_crashlog_in_scripted_process(debugger, crash_log_file, options, result):
-    crashlog_path = os.path.expanduser(crash_log_file)
-    if not os.path.exists(crashlog_path):
-        raise InteractiveCrashLogException(
-            "crashlog file %s does not exist" % crashlog_path
-        )
-
+def load_crashlog_in_scripted_process(debugger, crashlog_path, options, result):
     crashlog = CrashLogParser.create(debugger, crashlog_path, False).parse()
 
     target = lldb.SBTarget()
     # 1. Try to use the user-provided target
     if options.target_path:
         target = debugger.CreateTarget(options.target_path)
         if not target:
             raise InteractiveCrashLogException(
def should_run_in_interactive_mode(options, ci):
         # elif ci and ci.IsInteractive():
         #     return True
         else:
             return False
 
     ci = debugger.GetCommandInterpreter()
 
     if args:
-        for crash_log_file in args:
+        for crashlog_file in args:
+            crashlog_path = os.path.expanduser(crashlog_file)
+            if not os.path.exists(crashlog_path):
+                raise FileNotFoundError(
+                    "crashlog file %s does not exist" % crashlog_path
+                )
             if should_run_in_interactive_mode(options, ci):
                 try:
                     load_crashlog_in_scripted_process(
-                        debugger, crash_log_file, options, result
+                        debugger, crashlog_path, options, result
                     )
                 except InteractiveCrashLogException as e:
                     result.SetError(str(e))
             else:
                 crash_log = CrashLogParser.create(
-                    debugger, crash_log_file, options.verbose
+                    debugger, crashlog_path, options.verbose
                 ).parse()
                 SymbolicateCrashLog(crash_log, options)
 
 
 if __name__ == "__main__":
     # Create a new debugger instance
     debugger = lldb.SBDebugger.Create()
     result = lldb.SBCommandReturnObject()