This is an archive of the discontinued LLVM Phabricator instance.

[X86][MC] Use MCInstrDesc to access CondCode operand
ClosedPublic

Authored by Amir on Jun 1 2023, 1:48 PM.

Details

Summary

BOLT may add an extra MCOperand as annotation, making the number of operands in
MCInst different from MCInstrDesc information. A recent change broke our use as
the last operand is no longer a cond code.

Partially revert 287dd0142c08caad5b32628f3842dfd5d5c59d03 to rely on MCInstrDesc
to access CondCode operand.

Diff Detail

Event Timeline

Amir created this revision.Jun 1 2023, 1:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 1 2023, 1:48 PM
Amir requested review of this revision.Jun 1 2023, 1:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 1 2023, 1:48 PM
skan accepted this revision.Jun 1 2023, 5:49 PM

LGTM, thanks!

This revision is now accepted and ready to land.Jun 1 2023, 5:49 PM
This revision was automatically updated to reflect the committed changes.