This is an archive of the discontinued LLVM Phabricator instance.

[Sanitizers][Darwin][ASanABI] Fix architecture config for ASan Abi
ClosedPublic

Authored by thetruestblue on May 31 2023, 3:33 PM.

Details

Summary

Moved setting supported architecture to parent cmake configuration files
so they can be read by both lib and test CMakeList.txt.

Fixed issue with check-asan-abi that did not filter for current host architecture
which caused x86_64 bots to run Arm64 tests.

Added x86_64 as a supported arch to the test cmake file.

rdar://110017569

Diff Detail

Event Timeline

thetruestblue created this revision.May 31 2023, 3:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 31 2023, 3:33 PM
thetruestblue requested review of this revision.May 31 2023, 3:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 31 2023, 3:33 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
thetruestblue edited the summary of this revision. (Show Details)May 31 2023, 3:34 PM
rsundahl accepted this revision.May 31 2023, 4:42 PM

Tested this diff on both x86_64 and arm64. LGTM @thetruestblue. Thank you!

This revision is now accepted and ready to land.May 31 2023, 4:42 PM