Please use GitHub pull requests for new patches. Phabricator shutdown timeline

[clang][ConstantEmitter] have tryEmitPrivate try ConstExprEmitter fast-path first
AbandonedPublic
Actions

Authored by nickdesaulniers on May 26 2023, 10:42 AM.

Details

Reviewers

efriedma
rsmith

Summary

As suggested by @efriedma in:
https://reviews.llvm.org/D76096#4370369

Some minor code style fixes as well in
ConstantEmitter::tryEmitPrivateForVarInit.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

nickdesaulniers created this revision.May 26 2023, 10:42 AM

Herald added a project: Restricted Project. · View Herald TranscriptMay 26 2023, 10:42 AM

nickdesaulniers requested review of this revision.May 26 2023, 10:42 AM

Herald added a project: Restricted Project. · View Herald TranscriptMay 26 2023, 10:42 AM

Herald added a subscriber: cfe-commits. · View Herald Transcript

nickdesaulniers added reviewers: efriedma, rsmith.May 26 2023, 10:43 AM

nickdesaulniers removed a subscriber: efriedma.

one more style update

Did you intentionally skip moving the ConstExprEmitter call in tryEmitPrivateForVarInit? (VarDecl::evaluateValue calls the constant evaluator.)

In D151572#4376697, @efriedma wrote:

Did you intentionally skip moving the ConstExprEmitter call in tryEmitPrivateForVarInit? (VarDecl::evaluateValue calls the constant evaluator.)

Yes, I'll do that in a follow up patch as it results in quite a few test failures that I'm looking into now. Triple check my messages on LLVM Discord. ;)

Harbormaster completed remote builds in B234911: Diff 526131.May 27 2023, 10:15 AM

nickdesaulniers added a child revision: D151587: [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first.Jun 1 2023, 11:35 AM

nickdesaulniers mentioned this in D151587: [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first.Jun 8 2023, 2:37 PM