As suggested by @efriedma in:
https://reviews.llvm.org/D76096#4370369
Some minor code style fixes as well in
ConstantEmitter::tryEmitPrivateForVarInit.
Differential D151572
[clang][ConstantEmitter] have tryEmitPrivate try ConstExprEmitter fast-path first nickdesaulniers on May 26 2023, 10:42 AM. Authored by
Details As suggested by @efriedma in: Some minor code style fixes as well in
Diff Detail
Event TimelineComment Actions Did you intentionally skip moving the ConstExprEmitter call in tryEmitPrivateForVarInit? (VarDecl::evaluateValue calls the constant evaluator.) Comment Actions Yes, I'll do that in a follow up patch as it results in quite a few test failures that I'm looking into now. Triple check my messages on LLVM Discord. ;) |