This is an archive of the discontinued LLVM Phabricator instance.

[CGP] Disable default copy ctor and copy assignment operator for InstructionRemover
ClosedPublic

Authored by yubing on May 26 2023, 1:45 AM.

Details

Summary

class InstructionRemover manages resources such as dynamically allocated memory, it's generally a good practice to either implement a custom copy constructor or disable the default one.

Diff Detail

Event Timeline

yubing created this revision.May 26 2023, 1:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 26 2023, 1:45 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
yubing requested review of this revision.May 26 2023, 1:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 26 2023, 1:45 AM
yubing retitled this revision from [CGP] Disable default copy ctor and assignment operator for InstructionRemover InstructionRemover manages resources such as dynamically allocated memory, it's generally a good practice to either implement a custom copy constructor or disable the... to [CGP] Disable default copy ctor and assignment operator for InstructionRemover .May 26 2023, 1:45 AM
yubing edited the summary of this revision. (Show Details)
yubing added a reviewer: pengfei.
yubing retitled this revision from [CGP] Disable default copy ctor and assignment operator for InstructionRemover to [CGP] Disable default copy ctor and copy assignment operator for InstructionRemover .May 26 2023, 1:48 AM
pengfei accepted this revision.May 26 2023, 1:53 AM

LGTM.

This revision is now accepted and ready to land.May 26 2023, 1:53 AM