This is an archive of the discontinued LLVM Phabricator instance.

[ModuleInliner] Try moving function-simplification before module inliner
AbandonedPublic

Authored by mingmingl on May 24 2023, 3:01 PM.

Details

Reviewers
kazu
mtrofin

Diff Detail

Event Timeline

mingmingl created this revision.May 24 2023, 3:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2023, 3:01 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
mingmingl requested review of this revision.May 24 2023, 3:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2023, 3:01 PM
mingmingl updated this revision to Diff 527260.May 31 2023, 6:59 PM
mingmingl retitled this revision from [ModuleInliner] Add two cgscc pass in module-inliner pipeline for simplication parity. to [ModuleInliner] Try moving function-simplification before module inliner.
mingmingl edited the summary of this revision. (Show Details)

Turns out the improvement I saw is an artifact of testing flow (in a/b or b/a, test is always worse than base for a reason when I enable new changes in baseline). Thanks for the offline discussions!

Plan to move function-simplication before module inliner and see how it works out.

mingmingl planned changes to this revision.May 31 2023, 6:59 PM
mingmingl abandoned this revision.Sep 20 2023, 2:30 PM