[MLIR] Add a missing pattern to MathToSpirv Conversion pass

[nbpatel]

Summary

The MathToSpirv conversion pass missed out a pattern for converting
math::AbsIOP to spirv::CLSAbsOp

[nbpatel]

Thanks for accepting the patch @antiagainst . Can you please merge it in as well as I dont have the access to merge?

[antiagainst]

In D151378#4370028, @nbpatel wrote:

Thanks for accepting the patch @antiagainst . Can you please merge it in as well as I dont have the access to merge?

Sure. What git author line should I use? arc patch doesn't show it for me.

[nbpatel]

Name: Nishant Patel
Email: [e-mail]

mlir/lib/Conversion/MathToSPIRV/MathToSPIRV.cpp

patterns
            CheckedElementwiseOpPattern<math::SinOp, spirv::GLSinOp>,
            CheckedElementwiseOpPattern<math::SqrtOp, spirv::GLSqrtOp>,
            CheckedElementwiseOpPattern<math::TanhOp, spirv::GLTanhOp>>(
           typeConverter, patterns.getContext());
 
   // OpenCL patterns
   patterns.add<Log1pOpPattern<spirv::CLLogOp>, ExpM1OpPattern<spirv::CLExpOp>,
                CheckedElementwiseOpPattern<math::AbsFOp, spirv::CLFAbsOp>,
+               CheckedElementwiseOpPattern<math::AbsIOp, spirv::CLSAbsOp>,
                CheckedElementwiseOpPattern<math::CeilOp, spirv::CLCeilOp>,
                CheckedElementwiseOpPattern<math::CosOp, spirv::CLCosOp>,
                CheckedElementwiseOpPattern<math::ErfOp, spirv::CLErfOp>,
                CheckedElementwiseOpPattern<math::ExpOp, spirv::CLExpOp>,
                CheckedElementwiseOpPattern<math::FloorOp, spirv::CLFloorOp>,
                CheckedElementwiseOpPattern<math::FmaOp, spirv::CLFmaOp>,
                CheckedElementwiseOpPattern<math::LogOp, spirv::CLLogOp>,
                CheckedElementwiseOpPattern<math::PowFOp, spirv::CLPowOp>,

mlir/test/Conversion/MathToSPIRV/math-to-opencl-spirv.mlir

 // CHECK-LABEL: @float32_ternary_vector
 func.func @float32_ternary_vector(%a: vector<4xf32>, %b: vector<4xf32>,
                             %c: vector<4xf32>) {
   // CHECK: spirv.CL.fma %{{.*}}: vector<4xf32>
   %0 = math.fma %a, %b, %c : vector<4xf32>
   return
 }
 
+// CHECK-LABEL: @int_unary
+func.func @int_unary(%arg0: i32) {
+  // CHECK: spirv.CL.s_abs %{{.*}}
+  %0 = math.absi %arg0 : i32
+  return
+}
+
 } // end module
 
 // -----
 
 module attributes {
   spirv.target_env = #spirv.target_env<#spirv.vce<v1.0, [Shader], []>, #spirv.resource_limits<>>
 } {