This was required due to a diagnostic change in Clang 15, which is the oldest Clang we now support.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Event Timeline
libcxx/test/libcxx/atomics/atomics.types.operations/atomics.types.operations.req/atomic_fetch_add.verify.cpp | ||
---|---|---|
49 | I'm compiling with Apple Clang 14.0.3 which returns "static_assert" but the CI returns "static assertion". I was wondering how to handle that in my tests. I guess that's the way. Wouldn't this change make these tests unusable on Apple Clang 14.0.3 which is supposed to be Clang 15? |
I don't know if Xcode 14.3 (Apple Clang 14.0.3 base on LLVM15) is a supported compiler but it still outputs static_assert and quotes in the static assert messages unlike the compiler on the CI, which outputs static assertion and no quotes.
I need still:
/ expected-error-re@*:* {{{{(static_assert|static assertion)}} failed due to requirement 'is_same<int, std::pair<const int, int>>::value'{{.*}}Allocator::value_type must be same type as value_type}} }
An example from memory:
static_assert failed due to requirement 'is_same<int, std::pair<const int, int>>::value' "Allocator::value_type must be same type as value_type"
vs
static assertion failed due to requirement 'is_same<int, std::pair<const int, int>>::value' Allocator::value_type must be same type as value_type
I'm compiling with Apple Clang 14.0.3 which returns "static_assert" but the CI returns "static assertion". I was wondering how to handle that in my tests. I guess that's the way. Wouldn't this change make these tests unusable on Apple Clang 14.0.3 which is supposed to be Clang 15?