This is an archive of the discontinued LLVM Phabricator instance.

[X86] Don't crash on instruction prefetch intrinsics without PREFETCHI support.
ClosedPublic

Authored by craig.topper on May 21 2023, 12:48 PM.

Details

Summary

Instead of failing to select during isel, drop the intrinsic in
lowering.

Fixes PR62839.

Diff Detail

Event Timeline

craig.topper created this revision.May 21 2023, 12:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 21 2023, 12:48 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
craig.topper requested review of this revision.May 21 2023, 12:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 21 2023, 12:48 PM
pengfei accepted this revision.May 21 2023, 5:52 PM

We have limited it in the FE. I was considering if we should lower it to other prefetch instructions if prefetchi is not supported. Some people have concern prefetching to data cache may not help with execution. Not emitting instruction seems good, thanks!

This revision is now accepted and ready to land.May 21 2023, 5:52 PM
This revision was landed with ongoing or failed builds.May 21 2023, 9:31 PM
This revision was automatically updated to reflect the committed changes.