This is an archive of the discontinued LLVM Phabricator instance.

[CMake][libc] Fix non-runtime build when other runtimes are enabled
ClosedPublic

Authored by aidengrossman on May 19 2023, 8:33 PM.

Details

Summary

Before this patch, when other runtimes were enabled by setting
LLVM_ENABLE_RUNTIMES and llvm libc was built as a project by setting
LLVM_ENABLE_PROJECTS, the llvm libc CMake system would delay
configuration until the runtime build which never started since libc
wasn't declared as one of the runtime builds. This patch fixes this
behavior by explicitly checking that libc is within LLVM_ENABLE_RUNTIMES
rather than just the variable being set at all.

Diff Detail

Event Timeline

aidengrossman created this revision.May 19 2023, 8:33 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 19 2023, 8:33 PM
aidengrossman requested review of this revision.May 19 2023, 8:33 PM
aidengrossman retitled this revision from CMake][libc] Fix non-runtime build when other runtimes are enabled to [CMake][libc] Fix non-runtime build when other runtimes are enabled.
lntue accepted this revision.May 20 2023, 10:02 AM
This revision is now accepted and ready to land.May 20 2023, 10:02 AM