This is an archive of the discontinued LLVM Phabricator instance.

Paths

Table of Contentst

-
libclc/
-
CMakeLists.txt

Differential D150871

libclc: fix linking against libLLVMSupport
AcceptedPublic

Authored by illwieckz on May 18 2023, 7:46 AM.

Download Raw Diff

Details

Reviewers

tstellar
nikic

Summary

Fixes:

[1/22] Linking CXX executable prepare_builtins
FAILED: prepare_builtins
: && /usr/bin/c++ -fno-lto -O3 -DNDEBUG -fno-lto     -Wl,-rpath-link,  -Wl,--gc-sections CMakeFiles/prepare_builtins.dir/utils/prepare-builtins.cpp.o -o prepare_builtins  -Wl,-rpath,"\$ORIGIN/../lib"  prefix/lib/libLLVMBitWriter.so.17git  prefix/lib/libLLVMBitReader.so.17git  prefix/lib/libLLVMCore.so.17git && :
/usr/bin/ld: CMakeFiles/prepare_builtins.dir/utils/prepare-builtins.cpp.o: undefined reference to symbol '_ZN4llvm2cl6Option11addArgumentEv'

Diff Detail

Unit TestsFailed

	Time	Test
	140 ms	x64 windows > LLVM.Object::bigarchive-malformed-header.test

Event Timeline

illwieckz created this revision.May 18 2023, 7:46 AM

Herald added a project: Restricted Project. · View Herald TranscriptMay 18 2023, 7:46 AM

Herald added a subscriber: jvesely. · View Herald Transcript

illwieckz requested review of this revision.May 18 2023, 7:46 AM

Herald added a project: Restricted Project. · View Herald TranscriptMay 18 2023, 7:46 AM

Herald added a subscriber: llvm-commits. · View Herald Transcript

illwieckz added a reviewer: tstellar.May 18 2023, 7:48 AM

I don't know when the regression happened, but 16.0.0 and current main (f56a738) are known to be affected. I assume it happened between 15 and 16 (I built some llvm 15 before without problem).

This fixes:

https://github.com/llvm/llvm-project/issues/62018

illwieckz edited the summary of this revision. (Show Details)May 18 2023, 7:52 AM

I sorted alphabetically the libraries to be linked with.

Harbormaster completed remote builds in B232871: Diff 523387.May 18 2023, 8:45 AM

illwieckz edited the summary of this revision. (Show Details)May 18 2023, 9:08 AM

LGTM. If you need me to commit this for you, can you please share the Name <email> to use?

This revision is now accepted and ready to land.May 18 2023, 9:13 AM

Herald added a subscriber: StephenFan. · View Herald TranscriptMay 18 2023, 9:13 AM

In D150871#4353153, @nikic wrote:

LGTM. If you need me to commit this for you, can you please share the Name <email> to use?

Thomas Debesse <dev@illwieckz.net>

Revision Contents

Path

Size

libclc/

CMakeLists.txt

1 line

Diff 523387

libclc/CMakeLists.txt

Context not available.
	BitReader	BitReader
	BitWriter	BitWriter
	Core	Core
		Support
	)	)
	add_llvm_executable( prepare_builtins utils/prepare-builtins.cpp )	add_llvm_executable( prepare_builtins utils/prepare-builtins.cpp )
	target_compile_definitions( prepare_builtins PRIVATE ${LLVM_VERSION_DEFINE} )	target_compile_definitions( prepare_builtins PRIVATE ${LLVM_VERSION_DEFINE} )
Context not available.