[libc++] Install GCC 13 in the docker containers

[philnik]

I haven't checked whether the container builds yet, since that doesn't work on arm Macs currently.

[Mordante]

Thanks for working on this. I was waiting for GCC-13 to be available in ppa to make this change.
It seems it's there for 3 days https://launchpad.net/~ubuntu-toolchain-r/+archive/ubuntu/test

(As a side note I wanted to update the Clang version in the CI to take advantage of -std=c++26 (landed yesterday), instead I wait for you to do that with this patch.)

I don't feel strongly about using jammy+ppa versus lunar, maybe @ldionne does, so I leave the final approval to him.

libcxx/utils/ci/Dockerfile

33

This change may break things, updating to Jammy had some issues. Can you make sure this works with our CI before committing?

[ldionne]

In D150695#4347160, @Mordante wrote:

I don't feel strongly about using jammy+ppa versus lunar, maybe @ldionne does, so I leave the final approval to him.

I don't have a preference either, as long as we're running on a stable version of Ubuntu. This is a stable version, right? We don't need LTS or anything, we just don't want something unstable (equivalent of ToT or whatever).

This LGTM but indeed it would be nice to test this before landing:

1. Build the image
2. Run one or two CI configurations just to make sure it works. Maybe the sanitizers since they sometimes seem more reliant on the OS?

[philnik]

Use PPA instead

libcxx/utils/ci/Dockerfile

 # A pre-built version of this image is maintained on DockerHub as ldionne/libcxx-builder.
 # To update the image, rebuild it and push it to ldionne/libcxx-builder (which
 # will obviously only work if you have permission to do so).
 #
 #   $ docker build -t ldionne/libcxx-builder libcxx/utils/ci
 #   $ docker push ldionne/libcxx-builder
 #
 
 FROM ubuntu:jammy
 
 # Make sure apt-get doesn't try to prompt for stuff like our time zone, etc.
 ENV DEBIAN_FRONTEND=noninteractive
 
 RUN apt-get update && apt-get install -y bash curl
 
 # Install various tools used by the build or the test suite
 #RUN apt-get update && apt-get install -y ninja-build python3 python3-sphinx python3-distutils python3-psutil git gdb

 
 # Install llvm-dev and libclang-dev to compile custom clang-tidy checks
 # TODO LLVM 17 revert D148831 to only install $(($LLVM_HEAD_VERSION - 1)) and $LLVM_HEAD_VERSION
 # The usage of the ToT version is needed due to module issues with Clang 16
 RUN apt-get update && apt-get install -y llvm-$(($LLVM_HEAD_VERSION - 2))-dev llvm-$(($LLVM_HEAD_VERSION - 1))-dev     llvm-$LLVM_HEAD_VERSION-dev \
                                      libclang-$(($LLVM_HEAD_VERSION - 2))-dev libclang-$(($LLVM_HEAD_VERSION - 1))-dev libclang-$LLVM_HEAD_VERSION-dev
 
 # Install the most recent GCC, like clang install the previous version as a transition.
-ENV GCC_LATEST_VERSION=12
+ENV GCC_LATEST_VERSION=13
+RUN add-apt-repository ppa:ubuntu-toolchain-r/test
 RUN apt-get update && apt install -y gcc-$((GCC_LATEST_VERSION - 1)) g++-$((GCC_LATEST_VERSION - 1))
 RUN apt-get update && apt install -y gcc-$GCC_LATEST_VERSION g++-$GCC_LATEST_VERSION
 
 # Remove all, no longer needed, apt data
 RUN rm -rf /var/lib/apt/lists/*
 
 # Install a recent CMake
 RUN wget https://github.com/Kitware/CMake/releases/download/v3.21.1/cmake-3.21.1-linux-x86_64.sh -O /tmp/install-cmake.sh