This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Deduplicate diagnostic codeaction fixes when the codeaction fixes multiple diagnostics
AcceptedPublic

Authored by hokein on May 15 2023, 2:18 AM.

Diff Detail

Event Timeline

hokein created this revision.May 15 2023, 2:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 15 2023, 2:18 AM
Herald added a subscriber: arphaman. · View Herald Transcript
hokein requested review of this revision.May 15 2023, 2:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 15 2023, 2:18 AM
kadircet accepted this revision.May 17 2023, 9:14 AM
kadircet added inline comments.
clang-tools-extra/clangd/ClangdLSPServer.cpp
1012–1013

can you revert these

1029–1033

i think it might be better to start with why;

Some code actions might fix multiple diagnostics and might be indistinguishable in the UI (e.g. they have the same title).
So we group them here.
This revision is now accepted and ready to land.May 17 2023, 9:14 AM