This is an archive of the discontinued LLVM Phabricator instance.

Differential D150533

[flang][runtime] Fixed dimension offset computation for MayAlias.
ClosedPublic

Authored by vzakhari on May 14 2023, 9:22 PM.

Details

Reviewers
klausler
Commits
rG7c7ffa7bab7e: [flang][runtime] Fixed dimension offset computation for MayAlias.

Diff Detail

Event Timeline

vzakhari created this revision.May 14 2023, 9:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 14 2023, 9:22 PM
Herald added subscribers: sunshaoce, jeroen.dobbelaere, jdoerfert. · View Herald Transcript
vzakhari requested review of this revision.May 14 2023, 9:22 PM
Harbormaster completed remote builds in B231888: Diff 522033.May 14 2023, 9:35 PM
klausler accepted this revision.May 15 2023, 8:05 AM
This revision is now accepted and ready to land.May 15 2023, 8:05 AM
Closed by commit rG7c7ffa7bab7e: [flang][runtime] Fixed dimension offset computation for MayAlias. (authored by vzakhari). · Explain WhyMay 15 2023, 10:49 AM
This revision was automatically updated to reflect the committed changes.
vzakhari added a commit: rG7c7ffa7bab7e: [flang][runtime] Fixed dimension offset computation for MayAlias..

Revision Contents

PathSize
flang/
runtime/
4 lines

Diff 522263

flang/runtime/assign.cpp

Show First 20 Lines • Show All 123 Lines • ▼ Show 20 Linesstatic void MaximalByteOffsetRange(
} }
int n{desc.raw().rank}; int n{desc.raw().rank};
for (int j{0}; j < n; ++j) { for (int j{0}; j < n; ++j) {
const auto &dim{desc.GetDimension(j)}; const auto &dim{desc.GetDimension(j)};
auto extent{dim.Extent()}; auto extent{dim.Extent()};
if (extent > 0) { if (extent > 0) {
auto sm{dim.ByteStride()}; auto sm{dim.ByteStride()};
if (sm < 0) { if (sm < 0) {
least += extent * sm; least += (extent - 1) * sm;
} else { } else {
most += extent * sm; most += (extent - 1) * sm;
} }
} }
} }
most += desc.ElementBytes() - 1; most += desc.ElementBytes() - 1;
} }
static inline bool RangesOverlap(const char *aStart, const char *aEnd, static inline bool RangesOverlap(const char *aStart, const char *aEnd,
const char *bStart, const char *bEnd) { const char *bStart, const char *bEnd) {
▲ Show 20 Lines • Show All 437 Lines • Show Last 20 Lines