[lldb] Correct elision of line zero in mixed disassembly

[kastiglione]

Summary

When disassemble --mixed is run, do not show source for line zero, as intended.

[kastiglione]

For testing, can anyone recommend a way to construct debug info with line entries that have line zero?

[kastiglione]

add Shell test

[aprantl]

lldb/test/Shell/Commands/command-disassemble-mixed.test

13

Can you add some positive check too? Otherwise this test succeeds even on an empty output..

[kastiglione]

add positive check

lldb/source/Core/Disassembler.cpp

bool Disassembler::ElideMixedSourceAndDisassemblyLine(
     SourceLine &line) {
 
   // TODO: should we also check target.process.thread.step-avoid-libraries ?
 
   const RegularExpression *avoid_regex = nullptr;
 
   // Skip any line #0 entries - they are implementation details
   if (line.line == 0)
-    return false;
+    return true;
 
   ThreadSP thread_sp = exe_ctx.GetThreadSP();
   if (thread_sp) {
     avoid_regex = thread_sp->GetSymbolsToAvoidRegexp();
   } else {
     TargetSP target_sp = exe_ctx.GetTargetSP();
     if (target_sp) {
       Status error;

lldb/test/Shell/Commands/command-disassemble-mixed.test

+extern int do_not_show;
+
+int main() {
+  int abc = 30;
+#line 0
+  return abc;
+}
+
+// RUN: %clang_host -g -x c -o a.out %s
+// RUN: %lldb -b -o 'disassemble --mixed -n main' a.out | FileCheck %s
+
+// CHECK: a.out`main:
+// CHECK-NOT: do_not_show