This is an archive of the discontinued LLVM Phabricator instance.

[asan][win][test] Disable interception_failure_test.cpp for static asan
ClosedPublic

Authored by alvinhochun on May 11 2023, 2:31 AM.

Details

Summary

This test checks that asan does not intercept user-provided libc
functions, but on Windows the static asan runtime does intercept static
copies of libc functions, so this test is invalid for said environment.
It used to fail from a different linker error, but this no longer
happens with newer WinSDK. Refer to comments on
https://reviews.llvm.org/D149549.

Diff Detail

Event Timeline

alvinhochun created this revision.May 11 2023, 2:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 11 2023, 2:31 AM
Herald added a subscriber: Enna1. · View Herald Transcript
alvinhochun requested review of this revision.May 11 2023, 2:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 11 2023, 2:31 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript

typo: profided

but on Windows the static asan runtime does intercept static copies of libc functions

can this change in future?

typo: profided

but on Windows the static asan runtime does intercept static copies of libc functions

can this change in future?

Probably not? To me it seems to be the nature of how the static sanitizer interception works on Windows. But I am not too familiar with the sanitizers, especially not with the static runtime.

ayzhao accepted this revision.May 12 2023, 1:37 PM

Thanks!

This revision is now accepted and ready to land.May 12 2023, 1:37 PM
vitalybuka accepted this revision.May 12 2023, 2:18 PM
alvinhochun edited the summary of this revision. (Show Details)

Update commit message and comment to reflect latest findings from D149549.