This is an archive of the discontinued LLVM Phabricator instance.

[libc++][AIX] Remove hardcode fail from format test
ClosedPublic

Authored by Jake-Egan on May 10 2023, 7:55 AM.

Details

Summary

The test is hardcoded to fail after passing test_ill_formed_utf16(). It passes on 32-bit AIX if we remove this.

Diff Detail

Event Timeline

Jake-Egan created this revision.May 10 2023, 7:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 10 2023, 7:55 AM
Jake-Egan requested review of this revision.May 10 2023, 7:55 AM
Mordante accepted this revision.Sep 4 2023, 10:28 AM

Sorry it seems I overlooked this patch. LGTM, can you rebase it before landing?

This revision is now accepted and ready to land.Sep 4 2023, 10:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 6 2023, 7:16 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
This revision now requires review to proceed.Sep 6 2023, 7:16 AM
Jake-Egan updated this revision to Diff 556031.Sep 6 2023, 7:18 AM

Restore patch (lost part of the patch when rebasing)

ldionne accepted this revision.Sep 7 2023, 9:17 AM
ldionne added a subscriber: ldionne.

Can we please land this?

This revision is now accepted and ready to land.Sep 7 2023, 9:17 AM

Sorry, I missed that you updated just yesterday. Thanks!

This revision was landed with ongoing or failed builds.Sep 8 2023, 10:40 AM
This revision was automatically updated to reflect the committed changes.