Page MenuHomePhabricator

francii (Michael Francis)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 3 2022, 12:33 PM (18 w, 22 h)

Recent Activity

Today

francii updated the diff for D137756: [z/OS][pg] Throw error when using -pg on z/OS.

Update test case verbosity

Tue, Feb 7, 9:04 AM · Restricted Project, Restricted Project

Yesterday

francii updated the diff for D137756: [z/OS][pg] Throw error when using -pg on z/OS.

Rebase and test case update

Mon, Feb 6, 1:50 PM · Restricted Project, Restricted Project

Fri, Feb 3

francii updated the diff for D140675: [AIX][libc++] Always opt in to _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION.

More information in test case description

Fri, Feb 3, 8:43 AM · Restricted Project, Restricted Project
francii updated the diff for D140675: [AIX][libc++] Always opt in to _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION.

Update test case main()

Fri, Feb 3, 8:23 AM · Restricted Project, Restricted Project

Thu, Feb 2

francii updated the diff for D140675: [AIX][libc++] Always opt in to _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION.

clang-format

Thu, Feb 2, 3:59 PM · Restricted Project, Restricted Project
francii updated the diff for D140675: [AIX][libc++] Always opt in to _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION.

Update test case comment

Thu, Feb 2, 10:34 AM · Restricted Project, Restricted Project
francii updated the diff for D140675: [AIX][libc++] Always opt in to _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION.

Update test case based on review

Thu, Feb 2, 10:29 AM · Restricted Project, Restricted Project
francii updated the diff for D140675: [AIX][libc++] Always opt in to _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION.

Update comment in __config

Thu, Feb 2, 10:21 AM · Restricted Project, Restricted Project
francii updated the diff for D140675: [AIX][libc++] Always opt in to _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION.

Update visibility line in test case

Thu, Feb 2, 10:19 AM · Restricted Project, Restricted Project
francii updated the diff for D140675: [AIX][libc++] Always opt in to _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION.

Update test case

Thu, Feb 2, 9:51 AM · Restricted Project, Restricted Project

Wed, Feb 1

francii updated the diff for D140675: [AIX][libc++] Always opt in to _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION.

Update test case

Wed, Feb 1, 9:13 PM · Restricted Project, Restricted Project

Mon, Jan 30

francii updated the diff for D137756: [z/OS][pg] Throw error when using -pg on z/OS.

Move check to Clang.cpp

Mon, Jan 30, 1:37 PM · Restricted Project, Restricted Project

Sat, Jan 28

francii updated the diff for D137753: [Clang][AIX][p]Enable -p Functionality.

Update based on review

Sat, Jan 28, 7:27 PM · Restricted Project, Restricted Project

Wed, Jan 25

francii added inline comments to D137753: [Clang][AIX][p]Enable -p Functionality.
Wed, Jan 25, 11:04 AM · Restricted Project, Restricted Project
francii updated the diff for D137753: [Clang][AIX][p]Enable -p Functionality.

Remove cc1 option

Wed, Jan 25, 11:02 AM · Restricted Project, Restricted Project

Tue, Jan 24

francii added a comment to D140675: [AIX][libc++] Always opt in to _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION.

I will update the test case to include the missing RUN lines.

Tue, Jan 24, 9:56 AM · Restricted Project, Restricted Project
francii updated the diff for D140675: [AIX][libc++] Always opt in to _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION.

Add missing test case

Tue, Jan 24, 9:52 AM · Restricted Project, Restricted Project

Mon, Jan 23

francii updated the diff for D137753: [Clang][AIX][p]Enable -p Functionality.

Rebase

Mon, Jan 23, 10:29 AM · Restricted Project, Restricted Project

Sun, Jan 22

francii updated the diff for D137753: [Clang][AIX][p]Enable -p Functionality.

Rebase

Sun, Jan 22, 1:36 PM · Restricted Project, Restricted Project

Thu, Jan 19

francii updated the summary of D137753: [Clang][AIX][p]Enable -p Functionality.
Thu, Jan 19, 12:54 PM · Restricted Project, Restricted Project
francii updated the diff for D137753: [Clang][AIX][p]Enable -p Functionality.

Specifically check for AIX before pushing pg

Thu, Jan 19, 12:53 PM · Restricted Project, Restricted Project

Wed, Jan 18

francii added a reviewer for D137753: [Clang][AIX][p]Enable -p Functionality: daltenty.
Wed, Jan 18, 11:41 AM · Restricted Project, Restricted Project
francii updated the diff for D137753: [Clang][AIX][p]Enable -p Functionality.

Remove codegen option approach

Wed, Jan 18, 11:38 AM · Restricted Project, Restricted Project
francii updated the diff for D140675: [AIX][libc++] Always opt in to _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION.

Updated fix

Wed, Jan 18, 8:27 AM · Restricted Project, Restricted Project

Wed, Jan 11

francii updated the diff for D140675: [AIX][libc++] Always opt in to _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION.

Do not remove from abi

Wed, Jan 11, 4:59 PM · Restricted Project, Restricted Project

Tue, Jan 10

francii updated the diff for D137753: [Clang][AIX][p]Enable -p Functionality.

Add supports profiling check

Tue, Jan 10, 11:34 AM · Restricted Project, Restricted Project

Jan 4 2023

francii added inline comments to D137756: [z/OS][pg] Throw error when using -pg on z/OS.
Jan 4 2023, 12:03 PM · Restricted Project, Restricted Project
francii added a comment to D137756: [z/OS][pg] Throw error when using -pg on z/OS.

Most targets reject -p now. It's unnecessary to have another z/OS specific diagnostic. So this patch can be abandoned.

% fclang -p a.cc
clang-16: error: unsupported option '-p' for target 'x86_64-unknown-linux-gnu'

@francii, if you can confirm:

  1. that there is a test that covers that error for z/OS, and
  2. any comments in the code associated with generating the error above do not misrepresent the rationale for why -p is unsupported on z/OS,

then I'm good with leaving it at that.

Otherwise, we should make this into an NFC patch that adds the test/adjusts the comments.

Jan 4 2023, 9:55 AM · Restricted Project, Restricted Project

Jan 3 2023

francii updated the diff for D140675: [AIX][libc++] Always opt in to _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION.

Rebase

Jan 3 2023, 4:06 AM · Restricted Project, Restricted Project

Dec 26 2022

francii retitled D137756: [z/OS][pg] Throw error when using -pg on z/OS from [z/OS][pg] Throw Error When Using -p or -pg on z/OS to [z/OS][pg] Throw error when using -pg on z/OS.
Dec 26 2022, 4:47 PM · Restricted Project, Restricted Project
francii updated the summary of D137756: [z/OS][pg] Throw error when using -pg on z/OS.
Dec 26 2022, 4:44 PM · Restricted Project, Restricted Project
francii added reviewers for D140675: [AIX][libc++] Always opt in to _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION: cebowleratibm, hubert.reinterpretcast, daltenty.
Dec 26 2022, 4:43 PM · Restricted Project, Restricted Project
francii requested review of D140675: [AIX][libc++] Always opt in to _LIBCPP_ABI_BAD_FUNCTION_CALL_KEY_FUNCTION.
Dec 26 2022, 4:41 PM · Restricted Project, Restricted Project

Dec 5 2022

francii retitled D137756: [z/OS][pg] Throw error when using -pg on z/OS from [z/OS][p][pg] Throw Error When Using -p or -pg on z/OS to [z/OS][pg] Throw Error When Using -p or -pg on z/OS.
Dec 5 2022, 4:40 PM · Restricted Project, Restricted Project
francii updated the diff for D137756: [z/OS][pg] Throw error when using -pg on z/OS.

Remove -p references

Dec 5 2022, 8:48 AM · Restricted Project, Restricted Project

Nov 22 2022

francii updated the diff for D137756: [z/OS][pg] Throw error when using -pg on z/OS.

Fix test case

Nov 22 2022, 10:04 AM · Restricted Project, Restricted Project
francii added a comment to D137756: [z/OS][pg] Throw error when using -pg on z/OS.
Nov 22 2022, 9:14 AM · Restricted Project, Restricted Project
francii added a comment to D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries.

Looks good but I just want to confirm that the profiled -L paths are appended in the correct order with respect to the non-profiled paths.

Nov 22 2022, 8:34 AM · Restricted Project, Restricted Project

Nov 18 2022

francii retitled D137753: [Clang][AIX][p]Enable -p Functionality from [Clang][GNU][AIX][p]Enable -p Functionality to [Clang][AIX][p]Enable -p Functionality.
Nov 18 2022, 7:15 PM · Restricted Project, Restricted Project
francii updated the diff for D137753: [Clang][AIX][p]Enable -p Functionality.

Remove Linux changes

Nov 18 2022, 7:15 PM · Restricted Project, Restricted Project
francii added a comment to D137753: [Clang][AIX][p]Enable -p Functionality.

Recall that the goal with -p is to create parity with GCC (at least with Linux and AIX), as per the RFC discussion.

Please make -p accepted for AIX only and don't change the semantics for other targets in this patch. For FreeBSD and Linux (musl and gnu) we can try rejecting -p. If OpenBSD wants to make -p an alias for -pg, that's fine.

We can make -p emit a message on Linux while also accepting it as an alias to -pg. Do you have a suggestion as to what that message would be?

The current warning: argument unused during compilation: '-p' [-Wunused-command-line-argument] is good for Linux.
In the future Linux can try removing -p.

The current behaviour of ignoring the option without stopping with an error return code is not a good one.

Recall that the goal is to create parity with GCC, as per the RFC post.

Is there a reason this flag shouldn't be supported on Linux? Specifically, what is your justification for diverging from GCC on this matter?

It's a legacy option (at least for Linux, FreeBSD, etc) and we don't want the usage to grow. I objected in the RFC, either. Note that the objection is not only from me, also from a Linux distro folk I checked with.

Nov 18 2022, 3:48 PM · Restricted Project, Restricted Project

Nov 17 2022

francii added a comment to D137753: [Clang][AIX][p]Enable -p Functionality.

Recall that the goal with -p is to create parity with GCC (at least with Linux and AIX), as per the RFC discussion.

Please make -p accepted for AIX only and don't change the semantics for other targets in this patch. For FreeBSD and Linux (musl and gnu) we can try rejecting -p. If OpenBSD wants to make -p an alias for -pg, that's fine.

We can make -p emit a message on Linux while also accepting it as an alias to -pg. Do you have a suggestion as to what that message would be?

The current warning: argument unused during compilation: '-p' [-Wunused-command-line-argument] is good for Linux.
In the future Linux can try removing -p.

The current behaviour of ignoring the option without stopping with an error return code is not a good one.

Recall that the goal is to create parity with GCC, as per the RFC post.

Is there a reason this flag shouldn't be supported on Linux? Specifically, what is your justification for diverging from GCC on this matter?

It's a legacy option (at least for Linux, FreeBSD, etc) and we don't want the usage to grow. I objected in the RFC, either. Note that the objection is not only from me, also from a Linux distro folk I checked with.

Nov 17 2022, 7:15 PM · Restricted Project, Restricted Project
francii added a comment to D137753: [Clang][AIX][p]Enable -p Functionality.

Recall that the goal with -p is to create parity with GCC (at least with Linux and AIX), as per the RFC discussion.

Nov 17 2022, 4:29 PM · Restricted Project, Restricted Project
francii added a comment to D137753: [Clang][AIX][p]Enable -p Functionality.

Please make -p accepted for AIX only and don't change the semantics for other targets in this patch. For FreeBSD and Linux (musl and gnu) we can try rejecting -p. If OpenBSD wants to make -p an alias for -pg, that's fine.

Nov 17 2022, 3:14 PM · Restricted Project, Restricted Project
francii updated the diff for D137753: [Clang][AIX][p]Enable -p Functionality.

Specify prof and gprof in help text

Nov 17 2022, 11:58 AM · Restricted Project, Restricted Project

Nov 14 2022

francii updated the diff for D137753: [Clang][AIX][p]Enable -p Functionality.

Add sysroot check to aix-ld.c test cases

Nov 14 2022, 12:28 PM · Restricted Project, Restricted Project
francii updated the diff for D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries.

Add sysroot to test cases

Nov 14 2022, 10:20 AM · Restricted Project, Restricted Project
francii updated the diff for D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries.

Remove check for -p

Nov 14 2022, 10:14 AM · Restricted Project, Restricted Project
francii updated the diff for D137753: [Clang][AIX][p]Enable -p Functionality.

Add profiled libraries check AIX

Nov 14 2022, 10:14 AM · Restricted Project, Restricted Project
francii updated the diff for D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries.

Fix mixup

Nov 14 2022, 10:10 AM · Restricted Project, Restricted Project
francii updated the diff for D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries.

Removed check for sysroot, it is not needed.

Nov 14 2022, 9:57 AM · Restricted Project, Restricted Project

Nov 13 2022

francii updated the diff for D137753: [Clang][AIX][p]Enable -p Functionality.

Updated Linux test case
Added profiled library search for AIX.

Nov 13 2022, 11:05 AM · Restricted Project, Restricted Project
francii updated the summary of D137753: [Clang][AIX][p]Enable -p Functionality.
Nov 13 2022, 11:01 AM · Restricted Project, Restricted Project
francii updated the diff for D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries.

Soft reset

Nov 13 2022, 10:55 AM · Restricted Project, Restricted Project
francii updated the diff for D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries.

Removed unnecessary variables

Nov 13 2022, 10:54 AM · Restricted Project, Restricted Project
francii updated the diff for D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries.

Add support for --sysroot

Nov 13 2022, 10:48 AM · Restricted Project, Restricted Project

Nov 10 2022

francii retitled D137753: [Clang][AIX][p]Enable -p Functionality from [Clang][GNU][AIX}[p]Enable -p Functionality to [Clang][GNU][AIX][p]Enable -p Functionality.
Nov 10 2022, 1:57 PM · Restricted Project, Restricted Project
francii updated the diff for D137753: [Clang][AIX][p]Enable -p Functionality.

Added Linux implementation and test case

Nov 10 2022, 1:45 PM · Restricted Project, Restricted Project
francii updated the summary of D137753: [Clang][AIX][p]Enable -p Functionality.
Nov 10 2022, 1:44 PM · Restricted Project, Restricted Project
francii retitled D137753: [Clang][AIX][p]Enable -p Functionality from [Clang][p]Enable -p Functionality to [Clang][GNU][AIX}[p]Enable -p Functionality.
Nov 10 2022, 1:42 PM · Restricted Project, Restricted Project

Nov 9 2022

francii added a reviewer for D137756: [z/OS][pg] Throw error when using -pg on z/OS: SeanP.
Nov 9 2022, 9:52 PM · Restricted Project, Restricted Project
francii updated the diff for D137756: [z/OS][pg] Throw error when using -pg on z/OS.

Use existing error

Nov 9 2022, 9:51 PM · Restricted Project, Restricted Project
francii updated the summary of D137756: [z/OS][pg] Throw error when using -pg on z/OS.
Nov 9 2022, 8:39 PM · Restricted Project, Restricted Project
francii updated the summary of D137756: [z/OS][pg] Throw error when using -pg on z/OS.
Nov 9 2022, 6:17 PM · Restricted Project, Restricted Project
francii added reviewers for D137756: [z/OS][pg] Throw error when using -pg on z/OS: hubert.reinterpretcast, cebowleratibm.
Nov 9 2022, 6:08 PM · Restricted Project, Restricted Project
francii requested review of D137756: [z/OS][pg] Throw error when using -pg on z/OS.
Nov 9 2022, 6:07 PM · Restricted Project, Restricted Project
francii updated the summary of D137753: [Clang][AIX][p]Enable -p Functionality.
Nov 9 2022, 5:38 PM · Restricted Project, Restricted Project
francii updated the diff for D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries.

Update the recently-created test cases

Nov 9 2022, 5:22 PM · Restricted Project, Restricted Project
francii added a comment to D137753: [Clang][AIX][p]Enable -p Functionality.
Nov 9 2022, 5:16 PM · Restricted Project, Restricted Project
francii added reviewers for D137753: [Clang][AIX][p]Enable -p Functionality: hubert.reinterpretcast, cebowleratibm.
Nov 9 2022, 5:14 PM · Restricted Project, Restricted Project
francii requested review of D137753: [Clang][AIX][p]Enable -p Functionality.
Nov 9 2022, 5:06 PM · Restricted Project, Restricted Project

Nov 8 2022

francii updated the summary of D137372: [Test][[AIX][pg] Add 32-bit linker invocation tests.
Nov 8 2022, 11:29 AM · Restricted Project, Restricted Project
francii updated the summary of D137373: [Test][[AIX][p] Add 64-bit linker invocation tests.
Nov 8 2022, 11:29 AM · Restricted Project, Restricted Project
francii retitled D137372: [Test][[AIX][pg] Add 32-bit linker invocation tests from [Test][[AIX][pg] Add 32-bit Test Case to Linker Tests to [Test][[AIX][pg] Add 32-bit linker invocation tests.
Nov 8 2022, 11:29 AM · Restricted Project, Restricted Project
francii retitled D137373: [Test][[AIX][p] Add 64-bit linker invocation tests from [Test][[AIX][p] Add 64-bit Test Case to Linker Tests to [Test][[AIX][p] Add 64-bit linker invocation tests.
Nov 8 2022, 11:29 AM · Restricted Project, Restricted Project

Nov 7 2022

francii retitled D137373: [Test][[AIX][p] Add 64-bit linker invocation tests from [AIX][p] Add 64-bit Test Case to Linker Tests to [Test][[AIX][p] Add 64-bit Test Case to Linker Tests.
Nov 7 2022, 9:25 AM · Restricted Project, Restricted Project
francii retitled D137372: [Test][[AIX][pg] Add 32-bit linker invocation tests from [AIX][pg] Add 32-bit Test Case to Linker Tests to [Test][[AIX][pg] Add 32-bit Test Case to Linker Tests.
Nov 7 2022, 9:25 AM · Restricted Project, Restricted Project
francii added a comment to D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries.

This needs a clang/test/Driver test. And, does this work with --sysroot= ?

Nov 7 2022, 8:14 AM · Restricted Project, Restricted Project

Nov 6 2022

francii updated the diff for D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries.

Including test case

Nov 6 2022, 5:22 PM · Restricted Project, Restricted Project
francii updated the summary of D137373: [Test][[AIX][p] Add 64-bit linker invocation tests.
Nov 6 2022, 4:58 PM · Restricted Project, Restricted Project
francii updated the summary of D137372: [Test][[AIX][pg] Add 32-bit linker invocation tests.
Nov 6 2022, 4:58 PM · Restricted Project, Restricted Project
francii retitled D137373: [Test][[AIX][p] Add 64-bit linker invocation tests from [AIX][p] Add 64-bit Test Case to [AIX][p] Add 64-bit Test Case to Linker Tests.
Nov 6 2022, 12:59 PM · Restricted Project, Restricted Project
francii retitled D137372: [Test][[AIX][pg] Add 32-bit linker invocation tests from [AIX][pg] Add 32-bit Test Case to [AIX][pg] Add 32-bit Test Case to Linker Tests.
Nov 6 2022, 12:59 PM · Restricted Project, Restricted Project
francii added a reviewer for D137372: [Test][[AIX][pg] Add 32-bit linker invocation tests: xingxue.
Nov 6 2022, 12:58 PM · Restricted Project, Restricted Project
francii added a reviewer for D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries: xingxue.
Nov 6 2022, 12:58 PM · Restricted Project, Restricted Project
francii added a reviewer for D137373: [Test][[AIX][p] Add 64-bit linker invocation tests: xingxue.
Nov 6 2022, 12:58 PM · Restricted Project, Restricted Project
francii updated the summary of D137373: [Test][[AIX][p] Add 64-bit linker invocation tests.
Nov 6 2022, 12:33 PM · Restricted Project, Restricted Project

Nov 3 2022

francii added reviewers for D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries: cebowleratibm, Huberti248.
Nov 3 2022, 4:09 PM · Restricted Project, Restricted Project
francii requested review of D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries.
Nov 3 2022, 4:08 PM · Restricted Project, Restricted Project
francii added reviewers for D137373: [Test][[AIX][p] Add 64-bit linker invocation tests: cebowleratibm, hubert.reinterpretcast.
Nov 3 2022, 4:00 PM · Restricted Project, Restricted Project
francii updated the summary of D137372: [Test][[AIX][pg] Add 32-bit linker invocation tests.
Nov 3 2022, 3:59 PM · Restricted Project, Restricted Project
francii requested review of D137373: [Test][[AIX][p] Add 64-bit linker invocation tests.
Nov 3 2022, 3:59 PM · Restricted Project, Restricted Project
francii retitled D137372: [Test][[AIX][pg] Add 32-bit linker invocation tests from [AIX][pg] Add 32-bit test case to [AIX][pg] Add 32-bit Test Case.
Nov 3 2022, 3:55 PM · Restricted Project, Restricted Project
francii added reviewers for D137372: [Test][[AIX][pg] Add 32-bit linker invocation tests: hubert.reinterpretcast, cebowleratibm.
Nov 3 2022, 3:54 PM · Restricted Project, Restricted Project
francii requested review of D137372: [Test][[AIX][pg] Add 32-bit linker invocation tests.
Nov 3 2022, 3:53 PM · Restricted Project, Restricted Project

Oct 17 2022

francii retitled D135384: [AIX] Fix mcount name and call arguments from [AIX] Fix mcount name and arguments to [AIX] Fix mcount name and call arguments.
Oct 17 2022, 12:47 PM · Restricted Project, Restricted Project, Restricted Project
francii retitled D135384: [AIX] Fix mcount name and call arguments from [AIX] Fix mcount name on AIX to [AIX] Fix mcount name and arguments.
Oct 17 2022, 12:45 PM · Restricted Project, Restricted Project, Restricted Project
francii retitled D135384: [AIX] Fix mcount name and call arguments from [AIX] Enable the use of the -pg flag to [AIX] Fix mcount name on AIX.
Oct 17 2022, 12:44 PM · Restricted Project, Restricted Project, Restricted Project
francii updated the summary of D135384: [AIX] Fix mcount name and call arguments.
Oct 17 2022, 12:41 PM · Restricted Project, Restricted Project, Restricted Project

Oct 13 2022

francii updated the diff for D135384: [AIX] Fix mcount name and call arguments.

Updated check for Func name

Oct 13 2022, 8:28 AM · Restricted Project, Restricted Project, Restricted Project