Update test case verbosity

Rebase and test case update

More information in test case description

Update test case main()

clang-format

Update test case comment

Update test case based on review

Update comment in __config

Update visibility line in test case

Update test case

Update test case

Move check to Clang.cpp

Update based on review

Remove cc1 option

I will update the test case to include the missing RUN lines.

Add missing test case

Rebase

Rebase

Specifically check for AIX before pushing pg

Remove codegen option approach

Updated fix

Do not remove from abi

Add supports profiling check

In D137756#4023531, @hubert.reinterpretcast wrote:

In D137756#4018666, @MaskRay wrote:

Most targets reject -p now. It's unnecessary to have another z/OS specific diagnostic. So this patch can be abandoned.

% fclang -p a.cc
clang-16: error: unsupported option '-p' for target 'x86_64-unknown-linux-gnu'

@francii, if you can confirm:

1. that there is a test that covers that error for z/OS, and
2. any comments in the code associated with generating the error above do not misrepresent the rationale for why -p is unsupported on z/OS,

then I'm good with leaving it at that.

Otherwise, we should make this into an NFC patch that adds the test/adjusts the comments.

Rebase

Remove -p references

Fix test case

In D137375#3943751, @cebowleratibm wrote:

Looks good but I just want to confirm that the profiled -L paths are appended in the correct order with respect to the non-profiled paths.

Remove Linux changes

In D137753#3935391, @MaskRay wrote:

In D137753#3935305, @francii wrote:

Recall that the goal with -p is to create parity with GCC (at least with Linux and AIX), as per the RFC discussion.

In D137753#3935138, @MaskRay wrote:

In D137753#3935126, @francii wrote:

In D137753#3934932, @MaskRay wrote:

Please make -p accepted for AIX only and don't change the semantics for other targets in this patch. For FreeBSD and Linux (musl and gnu) we can try rejecting -p. If OpenBSD wants to make -p an alias for -pg, that's fine.

We can make -p emit a message on Linux while also accepting it as an alias to -pg. Do you have a suggestion as to what that message would be?

The current warning: argument unused during compilation: '-p' [-Wunused-command-line-argument] is good for Linux.
In the future Linux can try removing -p.

The current behaviour of ignoring the option without stopping with an error return code is not a good one.

Recall that the goal is to create parity with GCC, as per the RFC post.

Is there a reason this flag shouldn't be supported on Linux? Specifically, what is your justification for diverging from GCC on this matter?

It's a legacy option (at least for Linux, FreeBSD, etc) and we don't want the usage to grow. I objected in the RFC, either. Note that the objection is not only from me, also from a Linux distro folk I checked with.

In D137753#3935391, @MaskRay wrote:

In D137753#3935305, @francii wrote:

Recall that the goal with -p is to create parity with GCC (at least with Linux and AIX), as per the RFC discussion.

In D137753#3935138, @MaskRay wrote:

In D137753#3935126, @francii wrote:

In D137753#3934932, @MaskRay wrote:

Please make -p accepted for AIX only and don't change the semantics for other targets in this patch. For FreeBSD and Linux (musl and gnu) we can try rejecting -p. If OpenBSD wants to make -p an alias for -pg, that's fine.

We can make -p emit a message on Linux while also accepting it as an alias to -pg. Do you have a suggestion as to what that message would be?

The current warning: argument unused during compilation: '-p' [-Wunused-command-line-argument] is good for Linux.
In the future Linux can try removing -p.

The current behaviour of ignoring the option without stopping with an error return code is not a good one.

Recall that the goal is to create parity with GCC, as per the RFC post.

Is there a reason this flag shouldn't be supported on Linux? Specifically, what is your justification for diverging from GCC on this matter?

It's a legacy option (at least for Linux, FreeBSD, etc) and we don't want the usage to grow. I objected in the RFC, either. Note that the objection is not only from me, also from a Linux distro folk I checked with.

Recall that the goal with -p is to create parity with GCC (at least with Linux and AIX), as per the RFC discussion.

In D137753#3934932, @MaskRay wrote:

Please make -p accepted for AIX only and don't change the semantics for other targets in this patch. For FreeBSD and Linux (musl and gnu) we can try rejecting -p. If OpenBSD wants to make -p an alias for -pg, that's fine.

Specify prof and gprof in help text

Add sysroot check to aix-ld.c test cases

Add sysroot to test cases

Remove check for -p

Add profiled libraries check AIX

Fix mixup

Removed check for sysroot, it is not needed.

Updated Linux test case
Added profiled library search for AIX.

Soft reset

Removed unnecessary variables

Add support for --sysroot

Added Linux implementation and test case

Use existing error

Update the recently-created test cases

In D137375#3906777, @MaskRay wrote:

This needs a clang/test/Driver test. And, does this work with --sysroot= ?

Including test case

Updated check for Func name