Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People francii

francii (Michael Francis)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 3 2022, 12:33 PM (51 w, 23 h)

Recent Activity
View All

Jul 26 2023

francii updated the diff for D148753: [libcxx] convert symbol checker from CMake target to lit test.

Rebase onto main

Jul 26 2023, 11:54 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii updated the diff for D150691: [runtimes] Refactor Symbol Checking Tool.

Improve readability of report_diff()

Jul 26 2023, 11:42 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii added a comment to D150691: [runtimes] Refactor Symbol Checking Tool.

@daltenty pinging for review

Jul 26 2023, 11:16 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii updated the diff for D150691: [runtimes] Refactor Symbol Checking Tool.

Formatting

Jul 26 2023, 11:16 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii added a comment to D150691: [runtimes] Refactor Symbol Checking Tool.

@ldionne re-pinging for review.

Jul 26 2023, 11:14 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii updated the diff for D150691: [runtimes] Refactor Symbol Checking Tool.

Rebase

Jul 26 2023, 11:13 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jun 27 2023

francii updated the diff for D150691: [runtimes] Refactor Symbol Checking Tool.

Cleanup

Jun 27 2023, 1:11 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii added a comment to D150691: [runtimes] Refactor Symbol Checking Tool.

@ldionne re-ping

Jun 27 2023, 12:03 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jun 13 2023

francii updated the diff for D148753: [libcxx] convert symbol checker from CMake target to lit test.

Rebase onto patch for symbol checking refactor.

Jun 13 2023, 11:31 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii updated the diff for D150691: [runtimes] Refactor Symbol Checking Tool.

Fix diff.py

Jun 13 2023, 10:24 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii updated the diff for D150691: [runtimes] Refactor Symbol Checking Tool.

Rebase and cleanup

Jun 13 2023, 10:12 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jun 4 2023

francii updated the diff for D150691: [runtimes] Refactor Symbol Checking Tool.

Rebase and update logic

Jun 4 2023, 11:05 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jun 1 2023

francii updated the diff for D150691: [runtimes] Refactor Symbol Checking Tool.

Rebase and update __init__.py

Jun 1 2023, 7:17 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 18 2023

francii added inline comments to D148753: [libcxx] convert symbol checker from CMake target to lit test.
May 18 2023, 9:39 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 16 2023

francii updated the diff for D150691: [runtimes] Refactor Symbol Checking Tool.

Consolidate similar logic found in utils and extract

May 16 2023, 4:49 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii added a comment to D150691: [runtimes] Refactor Symbol Checking Tool.

Using a simple C file:

#include <stdio.h>
May 16 2023, 1:33 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii updated the diff for D150691: [runtimes] Refactor Symbol Checking Tool.

Add args.removed_only

May 16 2023, 1:01 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii updated the diff for D150691: [runtimes] Refactor Symbol Checking Tool.

Fix count used for removed and changed symbols

May 16 2023, 12:41 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii updated the diff for D150691: [runtimes] Refactor Symbol Checking Tool.

Cleanup scripts, fixed circular import

May 16 2023, 12:38 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii added a comment to D150691: [runtimes] Refactor Symbol Checking Tool.
May 16 2023, 12:33 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii added a comment to D150691: [runtimes] Refactor Symbol Checking Tool.
May 16 2023, 11:29 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii updated the diff for D150691: [runtimes] Refactor Symbol Checking Tool.

Small cleanup

May 16 2023, 11:17 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii updated the summary of D150691: [runtimes] Refactor Symbol Checking Tool.
May 16 2023, 11:12 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii added a reviewer for D150691: [runtimes] Refactor Symbol Checking Tool: daltenty.
May 16 2023, 11:10 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii added inline comments to D150691: [runtimes] Refactor Symbol Checking Tool.
May 16 2023, 10:04 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii added a comment to D150691: [runtimes] Refactor Symbol Checking Tool.

@ldionne This is a prototype for a complete refactor of the symbol checker. There's a lot I don't know about other platforms and what we should expect to support, so please share your thoughts.

May 16 2023, 10:01 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii added a reviewer for D150691: [runtimes] Refactor Symbol Checking Tool: ldionne.
May 16 2023, 9:59 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii requested review of D150691: [runtimes] Refactor Symbol Checking Tool.
May 16 2023, 9:58 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 9 2023

francii added a reviewer for D150198: [LLVM][Support] AIX traceback functionality: bmahjour.
May 9 2023, 7:44 AM · Restricted Project, Restricted Project

May 8 2023

francii committed rG5da7f30f24c4: [AIX][Clang][K] Create `-K` Option for AIX. (authored by francii).
[AIX][Clang][K] Create `-K` Option for AIX.
May 8 2023, 3:54 PM · Restricted Project, Restricted Project
francii closed D146399: [AIX][Clang][K] Create `-K` Option for AIX..
May 8 2023, 3:54 PM · Restricted Project, Restricted Project
francii updated the diff for D146399: [AIX][Clang][K] Create `-K` Option for AIX..

Remove leftover marker

May 8 2023, 3:50 PM · Restricted Project, Restricted Project
francii updated the diff for D146399: [AIX][Clang][K] Create `-K` Option for AIX..

Don't claim -k when checking target

May 8 2023, 11:41 AM · Restricted Project, Restricted Project

May 4 2023

francii updated the diff for D148753: [libcxx] convert symbol checker from CMake target to lit test.

Update sym_diff.py path in lit test

May 4 2023, 7:35 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 3 2023

francii updated the diff for D148753: [libcxx] convert symbol checker from CMake target to lit test.

Update CMake target and run-buildbot function

May 3 2023, 1:58 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii added inline comments to D148753: [libcxx] convert symbol checker from CMake target to lit test.
May 3 2023, 1:49 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii updated the diff for D148753: [libcxx] convert symbol checker from CMake target to lit test.

Update lit test

May 3 2023, 8:27 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 2 2023

francii added a comment to D148753: [libcxx] convert symbol checker from CMake target to lit test.
In D148753#4314067, @paulkirth wrote:

s/tit/lit in title

May 2 2023, 4:20 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii retitled D148753: [libcxx] convert symbol checker from CMake target to lit test from [libcxx] convert symbol checker from CMake target to tit test to [libcxx] convert symbol checker from CMake target to lit test.
May 2 2023, 4:20 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii added inline comments to D148753: [libcxx] convert symbol checker from CMake target to lit test.
May 2 2023, 4:16 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii updated the diff for D148753: [libcxx] convert symbol checker from CMake target to lit test.

Update CMakeLists.txt

May 2 2023, 4:11 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii updated the summary of D148753: [libcxx] convert symbol checker from CMake target to lit test.
May 2 2023, 3:52 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii retitled D148753: [libcxx] convert symbol checker from CMake target to lit test from [libcxx] move abi symbol checker logic to generic location to [libcxx] convert symbol checker from CMake target to tit test.
May 2 2023, 3:51 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii added inline comments to D148753: [libcxx] convert symbol checker from CMake target to lit test.
May 2 2023, 3:45 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii added a comment to D148753: [libcxx] convert symbol checker from CMake target to lit test.

@ldionne I'd also like your input on how to handle the current generate-cxx-abilist target.

May 2 2023, 3:38 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii updated the diff for D148753: [libcxx] convert symbol checker from CMake target to lit test.

Create libc++ lit test

May 2 2023, 3:25 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii updated the diff for D148753: [libcxx] convert symbol checker from CMake target to lit test.

Add --only-stdlib-symbols option to generate_abi_list.py

May 2 2023, 3:16 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii updated the diff for D148753: [libcxx] convert symbol checker from CMake target to lit test.

Move files to runtimes/utils/

May 2 2023, 3:11 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii added a comment to D148753: [libcxx] convert symbol checker from CMake target to lit test.

I don't think we want to use the top-level utils/ directory for this, this is closely related to the runtimes. Maybe we could put it under runtimes/utils?

May 2 2023, 3:08 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 24 2023

francii added a comment to D148753: [libcxx] convert symbol checker from CMake target to lit test.

@ldionne please give your thoughts on everything laid out in the summary of this patch and let me know your thoughts

Apr 24 2023, 8:14 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 21 2023

francii updated the summary of D148753: [libcxx] convert symbol checker from CMake target to lit test.
Apr 21 2023, 3:29 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii updated the summary of D148753: [libcxx] convert symbol checker from CMake target to lit test.
Apr 21 2023, 3:28 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii updated the summary of D148753: [libcxx] convert symbol checker from CMake target to lit test.
Apr 21 2023, 3:27 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 20 2023

francii updated the summary of D148753: [libcxx] convert symbol checker from CMake target to lit test.
Apr 20 2023, 11:04 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii updated the summary of D148753: [libcxx] convert symbol checker from CMake target to lit test.
Apr 20 2023, 8:31 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii updated the diff for D148753: [libcxx] convert symbol checker from CMake target to lit test.

Rebase

Apr 20 2023, 8:27 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 19 2023

francii removed 1 blocking reviewer(s) for D148753: [libcxx] convert symbol checker from CMake target to lit test: ldionne.
Apr 19 2023, 4:07 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii added reviewers for D148753: [libcxx] convert symbol checker from CMake target to lit test: ldionne, daltenty, Jake-Egan.
Apr 19 2023, 4:06 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii updated the diff for D148753: [libcxx] convert symbol checker from CMake target to lit test.

Update CMakeLists.txt

Apr 19 2023, 4:05 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
francii requested review of D148753: [libcxx] convert symbol checker from CMake target to lit test.
Apr 19 2023, 4:03 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 6 2023

francii updated the diff for D146399: [AIX][Clang][K] Create `-K` Option for AIX..

Add unsupported target test case

Apr 6 2023, 8:45 AM · Restricted Project, Restricted Project

Apr 5 2023

francii updated the diff for D146399: [AIX][Clang][K] Create `-K` Option for AIX..

Add -c test case

Apr 5 2023, 2:26 PM · Restricted Project, Restricted Project

Apr 4 2023

francii added a comment to D146399: [AIX][Clang][K] Create `-K` Option for AIX..
In D146399#4243803, @hubert.reinterpretcast wrote:

@francii, what happens when -K is used on a pure-compile (-c) invocation? Do we get an "unused" message? Should we be testing that?
I think we should be testing the diagnostic for the "wrong target" usage as well?

Apr 4 2023, 2:33 PM · Restricted Project, Restricted Project

Mar 27 2023

francii updated the diff for D146399: [AIX][Clang][K] Create `-K` Option for AIX..

Remove NoArgumentUnused, claim -K when checking target.

Mar 27 2023, 9:48 AM · Restricted Project, Restricted Project

Mar 21 2023

francii committed rG4dc04557d71c: [AIX][r] Do not call AddFilePathLibArgs with -r (authored by francii).
[AIX][r] Do not call AddFilePathLibArgs with -r
Mar 21 2023, 7:26 PM · Restricted Project, Restricted Project
francii closed D146578: [AIX][r] Do not call AddFilePathLibArgs with -r.
Mar 21 2023, 7:26 PM · Restricted Project, Restricted Project
francii added a reviewer for D146578: [AIX][r] Do not call AddFilePathLibArgs with -r: abhina.sreeskantharajan.
Mar 21 2023, 3:17 PM · Restricted Project, Restricted Project
francii requested review of D146578: [AIX][r] Do not call AddFilePathLibArgs with -r.
Mar 21 2023, 3:08 PM · Restricted Project, Restricted Project

Mar 20 2023

francii committed rG4c483a046d2f: [AIX] Consolidate Crt0Basename logic (authored by francii).
[AIX] Consolidate Crt0Basename logic
Mar 20 2023, 5:47 PM · Restricted Project, Restricted Project
francii closed D146443: [AIX] Consolidate Crt0Basename logic.
Mar 20 2023, 5:47 PM · Restricted Project, Restricted Project
francii closed D137372: [Test][[AIX][pg] Add 32-bit linker invocation tests.

Closing as this revision has landed

Mar 20 2023, 5:46 PM · Restricted Project, Restricted Project
francii closed D137373: [Test][[AIX][p] Add 64-bit linker invocation tests.

Closing as this revision has landed

Mar 20 2023, 5:45 PM · Restricted Project, Restricted Project
francii closed D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries.

Closing as this revision has landed
https://reviews.llvm.org/rG0fae851824bc1b64a727aeb331b7a0787599bd1f

Mar 20 2023, 5:45 PM · Restricted Project, Restricted Project
francii updated the diff for D146443: [AIX] Consolidate Crt0Basename logic.

Rebase

Mar 20 2023, 12:40 PM · Restricted Project, Restricted Project
francii requested review of D146443: [AIX] Consolidate Crt0Basename logic.
Mar 20 2023, 11:02 AM · Restricted Project, Restricted Project
francii committed rG5259da75b935: [AIX][Clang] Respect -r when invoking the linker (authored by francii).
[AIX][Clang] Respect -r when invoking the linker
Mar 20 2023, 10:57 AM · Restricted Project, Restricted Project
francii closed D145899: [AIX][Clang] Respect -r when invoking the linker.
Mar 20 2023, 10:57 AM · Restricted Project, Restricted Project
francii updated the diff for D146399: [AIX][Clang][K] Create `-K` Option for AIX..

Clean up test case

Mar 20 2023, 7:34 AM · Restricted Project, Restricted Project
francii updated the diff for D145899: [AIX][Clang] Respect -r when invoking the linker.

Update test case

Mar 20 2023, 7:32 AM · Restricted Project, Restricted Project
francii updated the diff for D146399: [AIX][Clang][K] Create `-K` Option for AIX..

Add test case

Mar 20 2023, 7:25 AM · Restricted Project, Restricted Project

Mar 19 2023

francii updated the diff for D146399: [AIX][Clang][K] Create `-K` Option for AIX..

nit: spacing

Mar 19 2023, 4:01 PM · Restricted Project, Restricted Project
francii updated the summary of D146399: [AIX][Clang][K] Create `-K` Option for AIX..
Mar 19 2023, 3:56 PM · Restricted Project, Restricted Project
francii updated the summary of D146399: [AIX][Clang][K] Create `-K` Option for AIX..
Mar 19 2023, 3:56 PM · Restricted Project, Restricted Project
francii added reviewers for D146399: [AIX][Clang][K] Create `-K` Option for AIX.: daltenty, rzurob.
Mar 19 2023, 3:54 PM · Restricted Project, Restricted Project
francii requested review of D146399: [AIX][Clang][K] Create `-K` Option for AIX..
Mar 19 2023, 3:54 PM · Restricted Project, Restricted Project
francii updated the diff for D145899: [AIX][Clang] Respect -r when invoking the linker.

Allow user-specified -L and -l options

Mar 19 2023, 3:21 PM · Restricted Project, Restricted Project

Mar 15 2023

francii updated the diff for D145899: [AIX][Clang] Respect -r when invoking the linker.

Add missing bracket

Mar 15 2023, 8:20 PM · Restricted Project, Restricted Project
francii updated the diff for D145899: [AIX][Clang] Respect -r when invoking the linker.

Add missing bracket

Mar 15 2023, 8:16 PM · Restricted Project, Restricted Project
francii updated the diff for D145899: [AIX][Clang] Respect -r when invoking the linker.

Rebase

Mar 15 2023, 4:37 PM · Restricted Project, Restricted Project
francii committed rGac1d143b0ef9: [Clang][AIX][p] Manually Claim -p in front end (authored by francii).
[Clang][AIX][p] Manually Claim -p in front end
Mar 15 2023, 4:28 PM · Restricted Project, Restricted Project
francii closed D145021: [Clang][AIX][p] Manually claim -p in front end.
Mar 15 2023, 4:28 PM · Restricted Project, Restricted Project
francii updated the diff for D145021: [Clang][AIX][p] Manually claim -p in front end.

Rebase for push

Mar 15 2023, 4:27 PM · Restricted Project, Restricted Project
francii updated the diff for D145021: [Clang][AIX][p] Manually claim -p in front end.

Rebase

Mar 15 2023, 1:15 PM · Restricted Project, Restricted Project
francii updated the diff for D145021: [Clang][AIX][p] Manually claim -p in front end.

Don't claim when checking for object file

Mar 15 2023, 1:14 PM · Restricted Project, Restricted Project
francii updated the diff for D145021: [Clang][AIX][p] Manually claim -p in front end.

Fix segfault

Mar 15 2023, 10:34 AM · Restricted Project, Restricted Project

Mar 14 2023

francii updated the diff for D145899: [AIX][Clang] Respect -r when invoking the linker.

Wildcard check for -l.

Mar 14 2023, 1:31 PM · Restricted Project, Restricted Project
francii updated the diff for D145899: [AIX][Clang] Respect -r when invoking the linker.

Update test case

Mar 14 2023, 12:38 PM · Restricted Project, Restricted Project
francii abandoned D146073: Revert "Revert "[Clang][AIX][p] Manually Claim -p in front end"".
Mar 14 2023, 11:12 AM · Restricted Project, Restricted Project
francii updated the diff for D145021: [Clang][AIX][p] Manually claim -p in front end.

Make -p a CC1 option.

Mar 14 2023, 11:12 AM · Restricted Project, Restricted Project
francii reopened D145021: [Clang][AIX][p] Manually claim -p in front end.
Mar 14 2023, 11:11 AM · Restricted Project, Restricted Project