This is an archive of the discontinued LLVM Phabricator instance.

Differential D150069

[InstCombine] Precommit a test
ClosedPublic

Authored by peixin on May 7 2023, 8:02 AM.

Details

Reviewers
RKSimon
spatel
nikic
Commits
rG31dda3913f9d: [InstCombine] Precommit a test
Summary

This patch precommits a test for:
https://reviews.llvm.org/D148420

Diff Detail

Event Timeline

peixin created this revision.May 7 2023, 8:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 7 2023, 8:02 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
peixin requested review of this revision.May 7 2023, 8:02 AM
Herald added a subscriber: llvm-commits. · View Herald TranscriptMay 7 2023, 8:02 AM
peixin added a child revision: D148420: [InstCombine] Enhance select icmp and folding.May 7 2023, 8:05 AM
Harbormaster completed remote builds in B230498: Diff 520189.May 7 2023, 8:55 AM
peixin mentioned this in D148420: [InstCombine] Enhance select icmp and folding.May 18 2023, 11:39 PM
peixin updated this revision to Diff 538410.Jul 9 2023, 2:16 AM

Update test cases.

Harbormaster completed remote builds in B243968: Diff 538410.Jul 9 2023, 3:12 AM
nikic accepted this revision.Jul 11 2023, 7:03 AM

LGTM

llvm/test/Transforms/InstCombine/select-icmp-and-zero-shl.ll
46

Add an extra use of %tobool.not (pass to call) to prevent it from being converted to icmp eq.

This revision is now accepted and ready to land.Jul 11 2023, 7:03 AM
peixin added inline comments.Jul 11 2023, 7:23 AM
llvm/test/Transforms/InstCombine/select-icmp-and-zero-shl.ll
46

This is added on purpose. The case of not being converted is @test_multi_use below.

nikic added inline comments.Jul 11 2023, 7:41 AM
llvm/test/Transforms/InstCombine/select-icmp-and-zero-shl.ll
46

Oh sorry, ignore my comment.

Closed by commit rG31dda3913f9d: [InstCombine] Precommit a test (authored by peixin). · Explain WhyJul 12 2023, 3:46 AM
This revision was automatically updated to reflect the committed changes.
peixin added a commit: rG31dda3913f9d: [InstCombine] Precommit a test.

Revision Contents

PathSize
llvm/
test/
Transforms/
InstCombine/
188 lines
InstSimplify/
62 lines

Diff 539479

llvm/test/Transforms/InstCombine/select-icmp-and-zero-shl.ll

  • This file was added.
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt < %s -passes=instcombine -S | FileCheck %s
; (x << k) ? 2^k * x : 0 --> 2^k * x
define i32 @test_eq(i32 %x) {
; CHECK-LABEL: @test_eq(
; CHECK-NEXT: [[SHL_MASK:%.*]] = and i32 [[X:%.*]], 1073741823
; CHECK-NEXT: [[TOBOOL:%.*]] = icmp eq i32 [[SHL_MASK]], 0
; CHECK-NEXT: [[MUL:%.*]] = shl i32 [[X]], 2
; CHECK-NEXT: [[COND:%.*]] = select i1 [[TOBOOL]], i32 0, i32 [[MUL]]
; CHECK-NEXT: ret i32 [[COND]]
;
%shl.mask = and i32 %x, 1073741823
%tobool = icmp eq i32 %shl.mask, 0
%mul = shl i32 %x, 2
%cond = select i1 %tobool, i32 0, i32 %mul
ret i32 %cond
}
define <2 x i32> @test_eq_vect(<2 x i32> %x) {
; CHECK-LABEL: @test_eq_vect(
; CHECK-NEXT: [[SHL_MASK:%.*]] = and <2 x i32> [[X:%.*]], <i32 1073741823, i32 1073741823>
; CHECK-NEXT: [[TOBOOL:%.*]] = icmp eq <2 x i32> [[SHL_MASK]], zeroinitializer
; CHECK-NEXT: [[MUL:%.*]] = shl <2 x i32> [[X]], <i32 2, i32 2>
; CHECK-NEXT: [[COND:%.*]] = select <2 x i1> [[TOBOOL]], <2 x i32> zeroinitializer, <2 x i32> [[MUL]]
; CHECK-NEXT: ret <2 x i32> [[COND]]
;
%shl.mask = and <2 x i32> %x, <i32 1073741823, i32 1073741823>
%tobool = icmp eq <2 x i32> %shl.mask, zeroinitializer
%mul = shl <2 x i32> %x, <i32 2, i32 2>
%cond = select <2 x i1> %tobool, <2 x i32> zeroinitializer, <2 x i32> %mul
ret <2 x i32> %cond
}
define i32 @test_ne(i32 %x) {
; CHECK-LABEL: @test_ne(
; CHECK-NEXT: [[SHL_MASK:%.*]] = and i32 [[X:%.*]], 1073741823
; CHECK-NEXT: [[TOBOOL_NOT_NOT:%.*]] = icmp eq i32 [[SHL_MASK]], 0
; CHECK-NEXT: [[MUL:%.*]] = shl i32 [[X]], 2
; CHECK-NEXT: [[COND:%.*]] = select i1 [[TOBOOL_NOT_NOT]], i32 0, i32 [[MUL]]
; CHECK-NEXT: ret i32 [[COND]]
;
%shl.mask = and i32 %x, 1073741823
%tobool.not = icmp ne i32 %shl.mask, 0
%mul = shl i32 %x, 2
nikicUnsubmitted
Not Done
ReplyInline Actions

Add an extra use of %tobool.not (pass to call) to prevent it from being converted to icmp eq.

nikic: Add an extra use of `%tobool.not` (pass to call) to prevent it from being converted to icmp eq.
peixinAuthorUnsubmitted
Done
ReplyInline Actions

This is added on purpose. The case of not being converted is @test_multi_use below.

peixin: This is added on purpose. The case of not being converted is `@test_multi_use` below.
nikicUnsubmitted
Not Done
ReplyInline Actions

Oh sorry, ignore my comment.

nikic: Oh sorry, ignore my comment.
%cond = select i1 %tobool.not, i32 %mul, i32 0
ret i32 %cond
}
define <2 x i32> @test_ne_vect(<2 x i32> %x) {
; CHECK-LABEL: @test_ne_vect(
; CHECK-NEXT: [[SHL_MASK:%.*]] = and <2 x i32> [[X:%.*]], <i32 1073741823, i32 1073741823>
; CHECK-NEXT: [[TOBOOL_NOT_NOT:%.*]] = icmp eq <2 x i32> [[SHL_MASK]], zeroinitializer
; CHECK-NEXT: [[MUL:%.*]] = shl <2 x i32> [[X]], <i32 2, i32 2>
; CHECK-NEXT: [[COND:%.*]] = select <2 x i1> [[TOBOOL_NOT_NOT]], <2 x i32> zeroinitializer, <2 x i32> [[MUL]]
; CHECK-NEXT: ret <2 x i32> [[COND]]
;
%shl.mask = and <2 x i32> %x, <i32 1073741823, i32 1073741823>
%tobool.not = icmp ne <2 x i32> %shl.mask, zeroinitializer
%mul = shl <2 x i32> %x, <i32 2, i32 2>
%cond = select <2 x i1> %tobool.not, <2 x i32> %mul, <2 x i32> zeroinitializer
ret <2 x i32> %cond
}
define i32 @test_nuw_dropped(i32 %x) {
; CHECK-LABEL: @test_nuw_dropped(
; CHECK-NEXT: [[SHL_MASK:%.*]] = and i32 [[X:%.*]], 1073741823
; CHECK-NEXT: [[TOBOOL:%.*]] = icmp eq i32 [[SHL_MASK]], 0
; CHECK-NEXT: [[MUL:%.*]] = shl nuw i32 [[X]], 2
; CHECK-NEXT: [[COND:%.*]] = select i1 [[TOBOOL]], i32 0, i32 [[MUL]]
; CHECK-NEXT: ret i32 [[COND]]
;
%shl.mask = and i32 %x, 1073741823
%tobool = icmp eq i32 %shl.mask, 0
%mul = shl nuw i32 %x, 2
%cond = select i1 %tobool, i32 0, i32 %mul
ret i32 %cond
}
define i32 @test_nsw_dropped(i32 %x) {
; CHECK-LABEL: @test_nsw_dropped(
; CHECK-NEXT: [[SHL_MASK:%.*]] = and i32 [[X:%.*]], 1073741823
; CHECK-NEXT: [[TOBOOL:%.*]] = icmp eq i32 [[SHL_MASK]], 0
; CHECK-NEXT: [[MUL:%.*]] = shl nsw i32 [[X]], 2
; CHECK-NEXT: [[COND:%.*]] = select i1 [[TOBOOL]], i32 0, i32 [[MUL]]
; CHECK-NEXT: ret i32 [[COND]]
;
%shl.mask = and i32 %x, 1073741823
%tobool = icmp eq i32 %shl.mask, 0
%mul = shl nsw i32 %x, 2
%cond = select i1 %tobool, i32 0, i32 %mul
ret i32 %cond
}
declare void @use_multi(i32, i1, i32)
; This will not be canonicalized.
define i32 @test_multi_use(i32 %x) {
; CHECK-LABEL: @test_multi_use(
; CHECK-NEXT: [[SHL_MASK:%.*]] = and i32 [[X:%.*]], 1073741823
; CHECK-NEXT: [[TOBOOL_NOT:%.*]] = icmp ne i32 [[SHL_MASK]], 0
; CHECK-NEXT: [[MUL:%.*]] = shl i32 [[X]], 2
; CHECK-NEXT: [[COND:%.*]] = select i1 [[TOBOOL_NOT]], i32 [[MUL]], i32 0
; CHECK-NEXT: call void @use_multi(i32 [[SHL_MASK]], i1 [[TOBOOL_NOT]], i32 [[MUL]])
; CHECK-NEXT: ret i32 [[COND]]
;
%shl.mask = and i32 %x, 1073741823
%tobool.not = icmp ne i32 %shl.mask, 0
%mul = shl i32 %x, 2
%cond = select i1 %tobool.not, i32 %mul, i32 0
call void @use_multi(i32 %shl.mask, i1 %tobool.not, i32 %mul)
ret i32 %cond
}
define i32 @test_multi_use_nuw_dropped(i32 %x) {
; CHECK-LABEL: @test_multi_use_nuw_dropped(
; CHECK-NEXT: [[SHL_MASK:%.*]] = and i32 [[X:%.*]], 1073741823
; CHECK-NEXT: [[TOBOOL:%.*]] = icmp eq i32 [[SHL_MASK]], 0
; CHECK-NEXT: [[MUL:%.*]] = shl nuw i32 [[X]], 2
; CHECK-NEXT: [[COND:%.*]] = select i1 [[TOBOOL]], i32 0, i32 [[MUL]]
; CHECK-NEXT: call void @use_multi(i32 [[SHL_MASK]], i1 [[TOBOOL]], i32 [[MUL]])
; CHECK-NEXT: ret i32 [[COND]]
;
%shl.mask = and i32 %x, 1073741823
%tobool = icmp eq i32 %shl.mask, 0
%mul = shl nuw i32 %x, 2
%cond = select i1 %tobool, i32 0, i32 %mul
call void @use_multi(i32 %shl.mask, i1 %tobool, i32 %mul)
ret i32 %cond
}
define i32 @neg_test_bits_not_match(i32 %x) {
; CHECK-LABEL: @neg_test_bits_not_match(
; CHECK-NEXT: [[SHL_MASK:%.*]] = and i32 [[X:%.*]], 1073741823
; CHECK-NEXT: [[TOBOOL:%.*]] = icmp eq i32 [[SHL_MASK]], 0
; CHECK-NEXT: [[MUL:%.*]] = shl i32 [[X]], 3
; CHECK-NEXT: [[COND:%.*]] = select i1 [[TOBOOL]], i32 0, i32 [[MUL]]
; CHECK-NEXT: ret i32 [[COND]]
;
%shl.mask = and i32 %x, 1073741823
%tobool = icmp eq i32 %shl.mask, 0
%mul = shl i32 %x, 3
%cond = select i1 %tobool, i32 0, i32 %mul
ret i32 %cond
}
define i32 @neg_test_icmp_non_equality(i32 %x) {
; CHECK-LABEL: @neg_test_icmp_non_equality(
; CHECK-NEXT: [[MUL:%.*]] = shl i32 [[X:%.*]], 2
; CHECK-NEXT: ret i32 [[MUL]]
;
%shl.mask = and i32 %x, 1073741823
%tobool = icmp slt i32 %shl.mask, 0
%mul = shl i32 %x, 2
%cond = select i1 %tobool, i32 0, i32 %mul
ret i32 %cond
}
define i32 @neg_test_select_non_zero_constant(i32 %x) {
; CHECK-LABEL: @neg_test_select_non_zero_constant(
; CHECK-NEXT: [[SHL_MASK:%.*]] = and i32 [[X:%.*]], 1073741823
; CHECK-NEXT: [[TOBOOL:%.*]] = icmp eq i32 [[SHL_MASK]], 0
; CHECK-NEXT: [[MUL:%.*]] = shl i32 [[X]], 2
; CHECK-NEXT: [[COND:%.*]] = select i1 [[TOBOOL]], i32 1, i32 [[MUL]]
; CHECK-NEXT: ret i32 [[COND]]
;
%shl.mask = and i32 %x, 1073741823
%tobool = icmp eq i32 %shl.mask, 0
%mul = shl i32 %x, 2
%cond = select i1 %tobool, i32 1, i32 %mul
ret i32 %cond
}
define i32 @neg_test_icmp_non_zero_constant(i32 %x) {
; CHECK-LABEL: @neg_test_icmp_non_zero_constant(
; CHECK-NEXT: [[SHL_MASK:%.*]] = and i32 [[X:%.*]], 1073741823
; CHECK-NEXT: [[TOBOOL:%.*]] = icmp eq i32 [[SHL_MASK]], 1
; CHECK-NEXT: [[MUL:%.*]] = shl i32 [[X]], 2
; CHECK-NEXT: [[COND:%.*]] = select i1 [[TOBOOL]], i32 0, i32 [[MUL]]
; CHECK-NEXT: ret i32 [[COND]]
;
%shl.mask = and i32 %x, 1073741823
%tobool = icmp eq i32 %shl.mask, 1
%mul = shl i32 %x, 2
%cond = select i1 %tobool, i32 0, i32 %mul
ret i32 %cond
}

llvm/test/Transforms/InstSimplify/select.ll

Show First 20 Lines • Show All 1,341 Lines • ▼ Show 20 Lines
; ;
%eq42 = icmp eq i8 %x, 42 %eq42 = icmp eq i8 %x, 42
%neg = sub i8 0, %x %neg = sub i8 0, %x
%and = and i8 %neg, %x %and = and i8 %neg, %x
%sel = select i1 %eq42, i8 0, i8 %and %sel = select i1 %eq42, i8 0, i8 %and
ret i8 %sel ret i8 %sel
} }
; (x << k) ? 2^k * x : 0 --> 2^k * x
define i32 @select_icmp_and_shl(i32 %x) {
; CHECK-LABEL: @select_icmp_and_shl(
; CHECK-NEXT: [[SHL_MASK:%.*]] = and i32 [[X:%.*]], 1073741823
; CHECK-NEXT: [[TOBOOL_NOT:%.*]] = icmp eq i32 [[SHL_MASK]], 0
; CHECK-NEXT: [[MUL:%.*]] = shl i32 [[X]], 2
; CHECK-NEXT: [[COND:%.*]] = select i1 [[TOBOOL_NOT]], i32 0, i32 [[MUL]]
; CHECK-NEXT: ret i32 [[COND]]
;
%shl.mask = and i32 %x, 1073741823
%tobool.not = icmp eq i32 %shl.mask, 0
%mul = shl i32 %x, 2
%cond = select i1 %tobool.not, i32 0, i32 %mul
ret i32 %cond
}
define <2 x i32> @select_icmp_and_shl_vect(<2 x i32> %x) {
; CHECK-LABEL: @select_icmp_and_shl_vect(
; CHECK-NEXT: [[SHL_MASK:%.*]] = and <2 x i32> [[X:%.*]], <i32 1073741823, i32 1073741823>
; CHECK-NEXT: [[TOBOOL_NOT:%.*]] = icmp eq <2 x i32> [[SHL_MASK]], zeroinitializer
; CHECK-NEXT: [[MUL:%.*]] = shl <2 x i32> [[X]], <i32 2, i32 2>
; CHECK-NEXT: [[COND:%.*]] = select <2 x i1> [[TOBOOL_NOT]], <2 x i32> zeroinitializer, <2 x i32> [[MUL]]
; CHECK-NEXT: ret <2 x i32> [[COND]]
;
%shl.mask = and <2 x i32> %x, <i32 1073741823, i32 1073741823>
%tobool.not = icmp eq <2 x i32> %shl.mask, zeroinitializer
%mul = shl <2 x i32> %x, <i32 2, i32 2>
%cond = select <2 x i1> %tobool.not, <2 x i32> zeroinitializer, <2 x i32> %mul
ret <2 x i32> %cond
}
define i32 @select_icmp_and_shl2(i32 %x) {
; CHECK-LABEL: @select_icmp_and_shl2(
; CHECK-NEXT: [[SHL_MASK:%.*]] = and i32 [[X:%.*]], 1073741823
; CHECK-NEXT: [[TOBOOL_NOT:%.*]] = icmp ne i32 [[SHL_MASK]], 0
; CHECK-NEXT: [[MUL:%.*]] = shl i32 [[X]], 2
; CHECK-NEXT: [[COND:%.*]] = select i1 [[TOBOOL_NOT]], i32 [[MUL]], i32 0
; CHECK-NEXT: ret i32 [[COND]]
;
%shl.mask = and i32 %x, 1073741823
%tobool.not = icmp ne i32 %shl.mask, 0
%mul = shl i32 %x, 2
%cond = select i1 %tobool.not, i32 %mul, i32 0
ret i32 %cond
}
define <2 x i32> @select_icmp_and_shl2_vect(<2 x i32> %x) {
; CHECK-LABEL: @select_icmp_and_shl2_vect(
; CHECK-NEXT: [[SHL_MASK:%.*]] = and <2 x i32> [[X:%.*]], <i32 1073741823, i32 1073741823>
; CHECK-NEXT: [[TOBOOL_NOT:%.*]] = icmp ne <2 x i32> [[SHL_MASK]], zeroinitializer
; CHECK-NEXT: [[MUL:%.*]] = shl <2 x i32> [[X]], <i32 2, i32 2>
; CHECK-NEXT: [[COND:%.*]] = select <2 x i1> [[TOBOOL_NOT]], <2 x i32> [[MUL]], <2 x i32> zeroinitializer
; CHECK-NEXT: ret <2 x i32> [[COND]]
;
%shl.mask = and <2 x i32> %x, <i32 1073741823, i32 1073741823>
%tobool.not = icmp ne <2 x i32> %shl.mask, zeroinitializer
%mul = shl <2 x i32> %x, <i32 2, i32 2>
%cond = select <2 x i1> %tobool.not, <2 x i32> %mul, <2 x i32> zeroinitializer
ret <2 x i32> %cond
}
define ptr @select_op_replacement_in_phi(ptr %head) { define ptr @select_op_replacement_in_phi(ptr %head) {
; CHECK-LABEL: @select_op_replacement_in_phi( ; CHECK-LABEL: @select_op_replacement_in_phi(
; CHECK-NEXT: entry: ; CHECK-NEXT: entry:
; CHECK-NEXT: br label [[LOOP:%.*]] ; CHECK-NEXT: br label [[LOOP:%.*]]
; CHECK: loop: ; CHECK: loop:
; CHECK-NEXT: [[CURRENT:%.*]] = phi ptr [ [[HEAD:%.*]], [[ENTRY:%.*]] ], [ [[NEXT:%.*]], [[LATCH:%.*]] ] ; CHECK-NEXT: [[CURRENT:%.*]] = phi ptr [ [[HEAD:%.*]], [[ENTRY:%.*]] ], [ [[NEXT:%.*]], [[LATCH:%.*]] ]
; CHECK-NEXT: [[PREV:%.*]] = phi ptr [ null, [[ENTRY]] ], [ [[CURRENT]], [[LATCH]] ] ; CHECK-NEXT: [[PREV:%.*]] = phi ptr [ null, [[ENTRY]] ], [ [[CURRENT]], [[LATCH]] ]
; CHECK-NEXT: [[CURRENT_NULL:%.*]] = icmp eq ptr [[CURRENT]], null ; CHECK-NEXT: [[CURRENT_NULL:%.*]] = icmp eq ptr [[CURRENT]], null
▲ Show 20 Lines • Show All 142 Lines • Show Last 20 Lines