This is an archive of the discontinued LLVM Phabricator instance.

[libc++] test/libcxx/transitive_includes.sh.cpp dumps loads of unhelpful preprocessor output when it fails
ClosedPublic

Authored by iana on May 6 2023, 5:51 PM.

Details

Summary

Send stdout to dev/null since the preprocessor output isn't relevant to the test and is tons of noise when the test fails.

Diff Detail

Event Timeline

iana created this revision.May 6 2023, 5:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 6 2023, 5:51 PM
Herald added a subscriber: ributzka. · View Herald Transcript
iana requested review of this revision.May 6 2023, 5:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 6 2023, 5:51 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
iana added inline comments.May 6 2023, 6:04 PM
libcxx/test/libcxx/transitive_includes.sh.cpp
60

This is the only actual changed line, the rest of them were done by libcxx-generate-files. We could also do >&- to close stdout, but the internet suggests that's a bit spotty. Although it does work for at least clang, if people prefer that method.

philnik accepted this revision.May 6 2023, 6:09 PM
philnik added a subscriber: philnik.

LGTM with green CI. Thanks!

This revision is now accepted and ready to land.May 6 2023, 6:09 PM
Mordante accepted this revision.May 7 2023, 3:36 AM

Thanks I still wonder why we suddenly get more output, but LGTM!

iana added a comment.May 7 2023, 5:51 PM

Thanks I still wonder why we suddenly get more output, but LGTM!

I don't think we do suddenly get more output, I think it's always been this way. You just don't see stdout unless the test fails.

Thanks I still wonder why we suddenly get more output, but LGTM!

I don't think we do suddenly get more output, I think it's always been this way. You just don't see stdout unless the test fails.

I don't recall seeing that when I worked on patches to improve this test. But at least it's fixed now :-)