This is an archive of the discontinued LLVM Phabricator instance.

Hi @StephenFan, your change is causing 2 test failures on a few bots, and I notice the two tests also failed in the pre-merge testing. Can you try to fix the issue and revert if you need time to investigate?

https://lab.llvm.org/buildbot/#/builders/139/builds/40364
https://lab.llvm.org/buildbot/#/builders/216/builds/20942
https://lab.llvm.org/buildbot/#/builders/247/builds/4320
https://reviews.llvm.org/B230178

hans added a reverting change: rG706e8110573c: Revert "[ValutTracking] Use isGuaranteedNotToBePoison in impliesPoison".May 9 2023, 12:18 AM

Sorry for causing test failures on test bots. Recommit at https://reviews.llvm.org/rGf470922a299f6036259c703a534a9b1e60573df7

Revision Contents

Path

Size

llvm/

lib/

Analysis/

ValueTracking.cpp

2 lines

test/

Transforms/

InstCombine/

2012-03-10-InstCombine.ll

4 lines

Diff 520585

llvm/lib/Analysis/ValueTracking.cpp

This file is larger than 256 KB, so syntax highlighting is disabled by default.

Show First 20 Lines • Show All 6,683 Lines • ▼ Show 20 Lines	if (match(I, m_ExtractValue(m_WithOverflowInst(II))) &&
llvm::is_contained(II->args(), ValAssumedPoison)))		llvm::is_contained(II->args(), ValAssumedPoison)))
return true;		return true;
}		}
return false;		return false;
}		}

static bool impliesPoison(const Value ValAssumedPoison, const Value V,		static bool impliesPoison(const Value ValAssumedPoison, const Value V,
unsigned Depth) {		unsigned Depth) {
if (isGuaranteedNotToBeUndefOrPoison(ValAssumedPoison))		if (isGuaranteedNotToBePoison(ValAssumedPoison))
return true;		return true;

if (directlyImpliesPoison(ValAssumedPoison, V, /* Depth */ 0))		if (directlyImpliesPoison(ValAssumedPoison, V, /* Depth */ 0))
return true;		return true;

const unsigned MaxDepth = 2;		const unsigned MaxDepth = 2;
if (Depth >= MaxDepth)		if (Depth >= MaxDepth)
return false;		return false;
▲ Show 20 Lines • Show All 2,121 Lines • Show Last 20 Lines

llvm/test/Transforms/InstCombine/2012-03-10-InstCombine.ll

	Show First 20 Lines • Show All 54 Lines • ▼ Show 20 Lines
	; CHECK-NEXT: entry:			; CHECK-NEXT: entry:
	; CHECK-NEXT: [[D:%.*]] = alloca i8, align 1			; CHECK-NEXT: [[D:%.*]] = alloca i8, align 1
	; CHECK-NEXT: store i8 0, ptr [[D]], align 1			; CHECK-NEXT: store i8 0, ptr [[D]], align 1
	; CHECK-NEXT: [[CMP:%.]] = icmp ugt ptr [[D]], [[C:%.]]			; CHECK-NEXT: [[CMP:%.]] = icmp ugt ptr [[D]], [[C:%.]]
	; CHECK-NEXT: br i1 [[CMP]], label [[IF_ELSE:%.]], label [[IF_THEN:%.]]			; CHECK-NEXT: br i1 [[CMP]], label [[IF_ELSE:%.]], label [[IF_THEN:%.]]
	; CHECK: if.then:			; CHECK: if.then:
	; CHECK-NEXT: [[CMP2:%.]] = icmp ule ptr [[D]], [[F:%.]]			; CHECK-NEXT: [[CMP2:%.]] = icmp ule ptr [[D]], [[F:%.]]
	; CHECK-NEXT: [[NOT_CMP1:%.*]] = icmp uge ptr [[C]], [[F]]			; CHECK-NEXT: [[NOT_CMP1:%.*]] = icmp uge ptr [[C]], [[F]]
	; CHECK-NEXT: [[DOTCMP2:%.*]] = select i1 [[CMP2]], i1 [[NOT_CMP1]], i1 false			; CHECK-NEXT: [[DOTCMP2:%.*]] = and i1 [[CMP2]], [[NOT_CMP1]]
	; CHECK-NEXT: br label [[RETURN:%.*]]			; CHECK-NEXT: br label [[RETURN:%.*]]
	; CHECK: if.else:			; CHECK: if.else:
	; CHECK-NEXT: [[CMP5:%.*]] = icmp uge ptr [[D]], [[F]]			; CHECK-NEXT: [[CMP5:%.*]] = icmp uge ptr [[D]], [[F]]
	; CHECK-NEXT: [[NOT_CMP3:%.*]] = icmp ule ptr [[C]], [[F]]			; CHECK-NEXT: [[NOT_CMP3:%.*]] = icmp ule ptr [[C]], [[F]]
	; CHECK-NEXT: [[DOTCMP5:%.*]] = select i1 [[CMP5]], i1 [[NOT_CMP3]], i1 false			; CHECK-NEXT: [[DOTCMP5:%.*]] = and i1 [[CMP5]], [[NOT_CMP3]]
	; CHECK-NEXT: br label [[RETURN]]			; CHECK-NEXT: br label [[RETURN]]
	; CHECK: return:			; CHECK: return:
	; CHECK-NEXT: [[RETVAL_0_IN:%.*]] = phi i1 [ [[DOTCMP2]], [[IF_THEN]] ], [ [[DOTCMP5]], [[IF_ELSE]] ]			; CHECK-NEXT: [[RETVAL_0_IN:%.*]] = phi i1 [ [[DOTCMP2]], [[IF_THEN]] ], [ [[DOTCMP5]], [[IF_ELSE]] ]
	; CHECK-NEXT: [[RETVAL_0:%.*]] = zext i1 [[RETVAL_0_IN]] to i32			; CHECK-NEXT: [[RETVAL_0:%.*]] = zext i1 [[RETVAL_0_IN]] to i32
	; CHECK-NEXT: ret i32 [[RETVAL_0]]			; CHECK-NEXT: ret i32 [[RETVAL_0]]
	;			;
	entry:			entry:
	%d = alloca i8, align 1			%d = alloca i8, align 1
	Show All 23 Lines

This is an archive of the discontinued LLVM Phabricator instance.

[ValutTracking] Use isGuaranteedNotToBePoison in impliesPoisonClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 520585

llvm/lib/Analysis/ValueTracking.cpp

llvm/test/Transforms/InstCombine/2012-03-10-InstCombine.ll

[ValutTracking] Use isGuaranteedNotToBePoison in impliesPoison
ClosedPublic