- add the from_range_t constructors and the related deduction guides;
- add the insert_range/assign_range/etc. member functions.
(Note: this patch is split from https://reviews.llvm.org/D142335)
Paths
| Differential D149832
[libc++][ranges] Implement the changes to `basic_string` from P1206 (`ranges::to`): ClosedPublic Authored by var-const on May 4 2023, 2:42 AM.
Details
Summary
(Note: this patch is split from https://reviews.llvm.org/D142335)
Diff Detail
Unit TestsFailed Event Timelinevar-const added inline comments.
ldionne added inline comments.
This revision now requires changes to proceed.Jun 1 2023, 1:04 PM var-const marked 3 inline comments as done. Comment ActionsPartially address feedback and rebase.
var-const added inline comments.
ldionne added inline comments.
var-const marked 3 inline comments as done. Comment ActionsAddress feedback and rebase.
var-const added inline comments.
ldionne added inline comments.
This revision now requires changes to proceed.Jun 29 2023, 1:35 PM This revision is now accepted and ready to land.Jul 5 2023, 12:48 PM Closed by commit rGbaf6f91851ed: [libc++][ranges] Implement the changes to `basic_string` from P1206 (`ranges… (authored by varconst <varconsteq@gmail.com>). · Explain WhyJul 5 2023, 2:51 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 528676 libcxx/include/string
libcxx/test/std/strings/basic.string/string.cons/from_range.pass.cpp
libcxx/test/std/strings/basic.string/string.cons/from_range_deduction.pass.cpp
libcxx/test/std/strings/basic.string/string.cons/iter_alloc_deduction.pass.cpp
libcxx/test/std/strings/basic.string/string.modifiers/string_append/append_range.pass.cpp
libcxx/test/std/strings/basic.string/string.modifiers/string_assign/assign_range.pass.cpp
libcxx/test/std/strings/basic.string/string.modifiers/string_insert/insert_range.pass.cpp
libcxx/test/std/strings/basic.string/string.modifiers/string_replace/replace_with_range.pass.cpp
|
Original comment by @ldionne