- add the from_range_t constructors and the related deduction guides;
- add the push_range member function.
(Note: this patch is split from https://reviews.llvm.org/D142335)
Paths
| Differential D149829
[libc++][ranges] Implement the changes to container adaptors from P1206 (`ranges::to`): ClosedPublic Authored by var-const on May 4 2023, 2:28 AM.
Details
Summary
(Note: this patch is split from https://reviews.llvm.org/D142335)
Diff Detail
Event TimelineComment Actions This LGTM w/ a few comments! Thanks!
This revision is now accepted and ready to land.Jun 1 2023, 12:37 PM Closed by commit rG87f3ff3e55e6: [libc++][ranges] Implement the changes to container adaptors from P1206… (authored by varconst <varconsteq@gmail.com>). · Explain WhyJun 5 2023, 6:59 PM This revision was automatically updated to reflect the committed changes. Comment Actions We're seeing some failures related to the following tests in our CI after this patch. Other failures are masking our CI right now so I'm not 100% sure this is still an issue, but I didn't notice any forward fixes or reverts related to this change. Failing bot: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8779076649243827361/overview llvm-libc++-static.cfg.in :: /b/s/w/ir/x/w/staging/llvm_build/runtimes/runtimes-x86_64-unknown-linux-gnu-bins/test/libcxx/transitive_includes.gen.py/queue.sh.cpp ******************** Failed Tests (2): llvm-libc++-static.cfg.in :: /b/s/w/ir/x/w/staging/llvm_build/runtimes/runtimes-x86_64-unknown-linux-gnu-bins/test/libcxx/transitive_includes.gen.py/queue.sh.cpp llvm-libc++-static.cfg.in :: /b/s/w/ir/x/w/staging/llvm_build/runtimes/runtimes-x86_64-unknown-linux-gnu-bins/test/libcxx/transitive_includes.gen.py/stack.sh.cpp Testing Time: 318.39s Skipped : 18 Unsupported : 2666 Passed : 14168 Expectedly Failed: 102 Failed : 2 FAILED: CMakeFiles/check-runtimes /b/s/w/ir/x/w/staging/llvm_build/runtimes/runtimes-x86_64-unknown-linux-gnu-bins/CMakeFiles/check-runtimes Comment Actions
I committed a fix for this yesterday. Is this issue still present for you?
Revision Contents
Diff 528662 libcxx/include/queue
libcxx/include/stack
libcxx/test/libcxx/transitive_includes/cxx03.csv
libcxx/test/libcxx/transitive_includes/cxx11.csv
libcxx/test/libcxx/transitive_includes/cxx14.csv
libcxx/test/libcxx/transitive_includes/cxx17.csv
libcxx/test/libcxx/transitive_includes/cxx20.csv
libcxx/test/libcxx/transitive_includes/cxx23.csv
libcxx/test/std/containers/container.adaptors/from_range_container_adaptors.h
libcxx/test/std/containers/container.adaptors/priority.queue/priqueue.cons/deduct.pass.cpp
libcxx/test/std/containers/container.adaptors/priority.queue/priqueue.cons/from_range.pass.cpp
libcxx/test/std/containers/container.adaptors/priority.queue/priqueue.members/push_range.pass.cpp
libcxx/test/std/containers/container.adaptors/push_range_container_adaptors.h
libcxx/test/std/containers/container.adaptors/queue/queue.cons/deduct.pass.cpp
libcxx/test/std/containers/container.adaptors/queue/queue.cons/from_range.pass.cpp
libcxx/test/std/containers/container.adaptors/queue/queue.defn/push_range.pass.cpp
libcxx/test/std/containers/container.adaptors/stack/stack.cons/deduct.pass.cpp
libcxx/test/std/containers/container.adaptors/stack/stack.cons/from_range.pass.cpp
libcxx/test/std/containers/container.adaptors/stack/stack.defn/push_range.pass.cpp
libcxx/test/support/deduction_guides_sfinae_checks.h
libcxx/test/support/unwrap_container_adaptor.h
|
This include guard is wrong.