This is an archive of the discontinued LLVM Phabricator instance.

Differential D149607

[mlir][sparse] fix compiler warning in release build.
ClosedPublic

Authored by Peiming on May 1 2023, 11:59 AM.

Details

Reviewers
aartbik
nicolasvasilache
bixia
Commits
rG4ca1932776db: [mlir][sparse] fix compiler warning in release build.

Diff Detail

Event Timeline

Peiming created this revision.May 1 2023, 11:59 AM
Herald added a reviewer: aartbik. · View Herald TranscriptMay 1 2023, 11:59 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: bviyer, hanchung, jsetoain and 24 others. · View Herald Transcript
Peiming requested review of this revision.May 1 2023, 11:59 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptMay 1 2023, 11:59 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Peiming added a reviewer: bixia.May 1 2023, 12:00 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 1 2023, 12:03 PM
This revision was landed with ongoing or failed builds.
Closed by commit rG4ca1932776db: [mlir][sparse] fix compiler warning in release build. (authored by Peiming). · Explain Why
This revision was automatically updated to reflect the committed changes.
Peiming added a commit: rG4ca1932776db: [mlir][sparse] fix compiler warning in release build..

Revision Contents

PathSize
mlir/
lib/
Dialect/
SparseTensor/
Transforms/
1 line

Diff 518519

mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorCodegen.cpp

Show First 20 Lines • Show All 1,603 Lines • ▼ Show 20 Linesstruct SparseUnpackOpConverter : public OpConversionPattern<UnpackOp> {
LogicalResult LogicalResult
matchAndRewrite(UnpackOp op, OpAdaptor adaptor, matchAndRewrite(UnpackOp op, OpAdaptor adaptor,
ConversionPatternRewriter &rewriter) const override { ConversionPatternRewriter &rewriter) const override {
auto desc = getDescriptorFromTensorTuple(adaptor.getTensor()); auto desc = getDescriptorFromTensorTuple(adaptor.getTensor());
const auto srcTp = getSparseTensorType(op.getTensor()); const auto srcTp = getSparseTensorType(op.getTensor());
const unsigned nBatched = op.getNumBatchedLvls(); const unsigned nBatched = op.getNumBatchedLvls();
assert(isCOOType(srcTp.getEncoding(), nBatched, true) && assert(isCOOType(srcTp.getEncoding(), nBatched, true) &&
desc.getFields().size() == 4); // specifier + pos + crds + values desc.getFields().size() == 4); // specifier + pos + crds + values
(void)srcTp;
auto logicRes = nBatched == 0 auto logicRes = nBatched == 0
? genUnBatchedUnpackOp(op, desc, rewriter) ? genUnBatchedUnpackOp(op, desc, rewriter)
: genBatchedUnpackOp(op, nBatched, desc, rewriter); : genBatchedUnpackOp(op, nBatched, desc, rewriter);
Value posBuf = desc.getPosMemRef(nBatched); Value posBuf = desc.getPosMemRef(nBatched);
if (createDeallocs) { if (createDeallocs) {
// Unpack ends the lifetime of the sparse tensor. While the value array // Unpack ends the lifetime of the sparse tensor. While the value array
// and coordinate array are unpacked and returned, the position array // and coordinate array are unpacked and returned, the position array
▲ Show 20 Lines • Show All 184 Lines • Show Last 20 Lines